[PATCH v2 1/4] test: Include /sbin to the PATH when creating ext4 disk image

Andy Shevchenko
2021-02-11T14:46:46Z

On Thu, Feb 11, 2021 at 04:40:09PM +0200, Andy Shevchenko wrote:
> On some distributions the mkfs.ext4 is under /sbin and /sbin is not set
> for mere users. Include /sbin to the PATH when creating ext4 disk image,
> so that users won't get a scary traceback from Python.

Note, patches 1 and 4 may be applied to U-Boot sources directly (while patches
2 and 3 are based on top of dm/test-working). Moreover, patch 4 fixes a quite
annoying fix, without which I have got reprimanded by an admin of our build
system.

Please, consider to apply patch 4 ASAP.

> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: used '/sbin' as is (Simon)
> test/py/tests/test_env.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py
> index 940279651da0..9bed2f48d77e 100644
> --- a/test/py/tests/test_env.py
> +++ b/test/py/tests/test_env.py
> @@ -414,6 +414,8 @@ def mk_env_ext4(state_test_env):
> if os.path.exists(persistent):
> c.log.action('Disk image file ' + persistent + ' already exists')
> else:
> + # Some distributions do not add /sbin to the default PATH, where mkfs.ext4 lives
> + os.environ["PATH"] += os.pathsep + '/sbin'
> try:
> u_boot_utils.run_and_log(c, 'dd if=/dev/zero of=%s bs=1M count=16' % persistent)
> u_boot_utils.run_and_log(c, 'mkfs.ext4 %s' % persistent)
> --
> 2.30.0
>

--
With Best Regards,
Andy Shevchenko