From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test
Date: Tue, 16 Feb 2021 13:14:57 -0500 [thread overview]
Message-ID: <20210216181457.GX10169@bill-the-cat> (raw)
In-Reply-To: <20210125122357.414742-5-olteanv@gmail.com>
On Mon, Jan 25, 2021 at 02:23:54PM +0200, Vladimir Oltean wrote:
> From: Claudiu Manoil <claudiu.manoil@nxp.com>
>
> The DSA sandbox driver is used for unit testing the DSA class code.
> It implements a simple 2 port switch plus 1 CPU port, and uses a very
> simple tag to identify the ports.
> The DSA sandbox device is connected via CPU port to a regular Ethernet
> sandbox device, called 'dsa-test-eth, managed by the existing eth sandbox
> driver. The 'dsa-test-eth' is not intended for testing the eth class
> code however, but it is used to emulate traffic through the 'lan0' and
> 'lan1' front pannel switch ports. To achieve this the dsa sandbox driver
> registers a tx handler for the 'dsa-test-eth' device. The switch ports,
> labeled as 'lan0' and 'lan1', are also registered as eth devices by the
> dsa class code this time. So pinging through these switch ports is as
> easy as:
> => setenv ethact lan0
> => ping 1.2.3.5
>
> Unit tests for the dsa class code were also added. The 'dsa_probe'
> test exercises most API functions from dsa.h. The 'dsa' unit test
> simply exercises ARP/ICMP traffic through the two switch ports,
> including tag injection and extraction, with the help of the dsa
> sandbox driver.
> I took care to minimize the impact on the existing eth unit tests,
> though some adjustments needed to be made with the addition of
> extra eth interfaces used by the dsa unit tests. The additional eth
> interfaces also require MAC addresses, these have been added to the
> sandbox default environment.
>
> Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
This test does not pass for me. This can be seen at:
https://gitlab.denx.de/u-boot/u-boot/-/jobs/223660
Note that I'm still reviewing the rest of the series right now.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210216/18d5c6ad/attachment.sig>
next prev parent reply other threads:[~2021-02-16 18:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 12:23 [PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver Vladimir Oltean
2021-01-25 12:23 ` [PATCH v4 1/7] net: phy: fixed: support speeds of 2500 and 10000 Vladimir Oltean
2021-01-27 8:04 ` Claudiu Manoil
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 2/7] net: phy: introduce fixed_phy_create for DSA CPU ports Vladimir Oltean
2021-01-27 8:05 ` Claudiu Manoil
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 3/7] net: Introduce DSA class for Ethernet switches Vladimir Oltean
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 4/7] sandbox: Add a DSA sandbox driver and unit test Vladimir Oltean
2021-02-16 18:14 ` Tom Rini [this message]
2021-02-16 21:02 ` Vladimir Oltean
2021-02-16 21:13 ` Tom Rini
2021-02-16 21:21 ` Vladimir Oltean
2021-02-16 21:33 ` Michael Walle
2021-02-16 21:38 ` Tom Rini
2021-02-16 21:53 ` Vladimir Oltean
2021-02-16 21:55 ` Tom Rini
2021-02-16 21:58 ` Michael Walle
2021-02-16 22:15 ` Michael Walle
2021-02-16 22:23 ` Vladimir Oltean
2021-01-25 12:23 ` [PATCH v4 5/7] drivers: net: Add Felix DSA switch driver Vladimir Oltean
2021-02-16 21:55 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 6/7] arm: dts: ls1028a: Add Ethernet switch node and dependencies Vladimir Oltean
2021-01-25 12:33 ` Michael Walle
2021-02-16 21:56 ` Tom Rini
2021-01-25 12:23 ` [PATCH v4 7/7] configs: ls1028a: Enable the Ethernet switch driver in defconfig Vladimir Oltean
2021-02-16 21:56 ` Tom Rini
2021-01-25 13:02 ` [PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver Michael Walle
2021-01-25 13:04 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216181457.GX10169@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox