public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Oliver Graute <oliver.graute@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v5] net: tftp: Add client support for RFC 7440
Date: Wed, 17 Feb 2021 10:14:57 +0100	[thread overview]
Message-ID: <20210217091457.GC27281@optiplex> (raw)
In-Reply-To: <20200718203146.317254-1-rfried.dev@gmail.com>

On 18/07/20, Ramon Fried wrote:
> Add support for RFC 7440: "TFTP Windowsize Option".
> 
> This optional feature allows the client and server
> to negotiate a window size of consecutive blocks to send as an
> alternative for replacing the single-block lockstep schema.
> 
> windowsize can be defined statically during compilation by
> setting CONFIG_TFTP_WINDOWSIZE, or defined in runtime by
> setting an environment variable: "tftpwindowsize"
> If not defined, the windowsize is set to 1, meaning that it
> behaves as it was never defined.

this commit breaks my TFTP Setup. I run into lot of timeouts and most of
the times I can't load the kernel or the dtb.

Using ethernet at 5b040000 device
TFTP from server 192.168.100.99; our IP address is 192.168.100.96
Filename 'Image'.
Load address: 0x80280000
Loading: #T T T T T T T

On bisecting between 2020.07 and 2020.10 I stumbled across this commit.
reverting it fix the issue immediately.

Some clue why the default windowsize set 1 breaks it for me?

Best regards,

Oliver

  parent reply	other threads:[~2021-02-17  9:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18 20:31 [PATCH v5] net: tftp: Add client support for RFC 7440 Ramon Fried
2020-08-05 20:27 ` Tom Rini
2021-01-30 20:39   ` Suneel Garapati
2021-01-30 21:26     ` Ramon Fried
2021-02-01 22:27       ` Ramon Fried
2021-02-02 16:02         ` Suneel Garapati
2021-02-02 19:46           ` Ramon Fried
2021-02-02 22:23             ` Suneel Garapati
2021-02-03  8:01               ` Ramon Fried
2021-02-17  9:14 ` Oliver Graute [this message]
2021-02-17 10:00   ` Oliver Graute

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217091457.GC27281@optiplex \
    --to=oliver.graute@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox