public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [PATCH 5/5] pwm: sunxi: enable pwm0 support on sun7i
Date: Fri, 19 Feb 2021 11:21:31 +0000	[thread overview]
Message-ID: <20210219112131.232c982d@slackpad.fritz.box> (raw)
In-Reply-To: <20210218232622.883509-6-giulio.benetti@benettiengineering.com>

On Fri, 19 Feb 2021 00:26:20 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> From: Giulio Benetti <giulio.benetti@micronovasrl.com>
> 
> sun7i pwm is equal to sun4i and sun5i so enable pwm0 the same way for
> sun7i.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Looks alright, though I feel the pwm driver should look into the DT
to find the pin, like we do for sun8i_emac.c. But that's probably
another patch, so:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  arch/arm/include/asm/arch-sunxi/pwm.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-sunxi/pwm.h b/arch/arm/include/asm/arch-sunxi/pwm.h
> index b89bddd2e8..1a1c6e0c54 100644
> --- a/arch/arm/include/asm/arch-sunxi/pwm.h
> +++ b/arch/arm/include/asm/arch-sunxi/pwm.h
> @@ -26,7 +26,8 @@
>  
>  #define SUNXI_PWM_PERIOD_80PCT		0x04af03c0
>  
> -#if defined CONFIG_MACH_SUN4I || defined CONFIG_MACH_SUN5I
> +#if defined CONFIG_MACH_SUN4I || defined CONFIG_MACH_SUN5I || \
> +    defined CONFIG_MACH_SUN7I
>  #define SUNXI_PWM_PIN0			SUNXI_GPB(2)
>  #define SUNXI_PWM_MUX			SUN4I_GPB_PWM
>  #endif

  reply	other threads:[~2021-02-19 11:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 23:26 [PATCH 0/5] Add Micronova srl S027_3 board support Giulio Benetti
2021-02-18 23:26 ` [PATCH 1/5] arm: allwinner: dts: a20: add uart2_pa_pins Giulio Benetti
2021-02-19 11:04   ` Andre Przywara
2021-02-19 11:45     ` Giulio Benetti
2021-02-18 23:26 ` [PATCH 2/5] sunxi: allow SYS_BOARD to be set Giulio Benetti
2021-02-18 23:26 ` [PATCH 3/5] sunxi: add SYS_VENDOR to Kconfig Giulio Benetti
2021-02-18 23:26 ` [PATCH 4/5] sun7i: add support for Micronova srl s027_3 board Giulio Benetti
2021-02-19  1:44   ` Andre Przywara
2021-02-19 10:12     ` Giulio Benetti
2021-02-19 10:18       ` Giulio Benetti
2021-02-19 10:38         ` gianluca
2021-02-19 11:10           ` Giulio Benetti
2021-02-19 11:37       ` Andre Przywara
2021-02-19 15:27         ` Giulio Benetti
2021-02-20  1:57           ` Andre Przywara
2021-02-18 23:26 ` [PATCH 5/5] pwm: sunxi: enable pwm0 support on sun7i Giulio Benetti
2021-02-19 11:21   ` Andre Przywara [this message]
2021-02-18 23:28 ` [PATCH 0/5] Add Micronova srl S027_3 board support Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219112131.232c982d@slackpad.fritz.box \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox