From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 19 Feb 2021 11:55:10 -0500 Subject: [PATCH v4 2/8] spl: fit: Factor out FIT parsing and use a context struct In-Reply-To: <20210120164656.1396639-3-mr.nuke.me@gmail.com> References: <20210120164656.1396639-1-mr.nuke.me@gmail.com> <20210120164656.1396639-3-mr.nuke.me@gmail.com> Message-ID: <20210219165510.GP10169@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 20, 2021 at 10:46:50AM -0600, Alexandru Gagniuc wrote: > The logical steps in spl_load_simple_fit() are difficult to follow. > I think the long comments, ifdefs, and ungodly number of variables > seriously affect the readability. In particular, it violates section 6 > of the coding style, paragraphs (3), and (4). > > The purpose of this patch is to improve the situation by > - Factoring out initialization and parsing to separate functions > - Reduce the number of variables by using a context structure > This change introduces no functional changes. > > Signed-off-by: Alexandru Gagniuc > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: