From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 19 Feb 2021 11:55:22 -0500 Subject: [PATCH v4 4/8] spl: fit: Remove useless loop in spl_fit_get_image_name() In-Reply-To: <20210120164656.1396639-5-mr.nuke.me@gmail.com> References: <20210120164656.1396639-1-mr.nuke.me@gmail.com> <20210120164656.1396639-5-mr.nuke.me@gmail.com> Message-ID: <20210219165522.GR10169@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 20, 2021 at 10:46:52AM -0600, Alexandru Gagniuc wrote: > When a desired configuration is not found, conf_node will have a > negative value. Thus the for loop will start at the root "/" node of > the image, print the "/description" property, and stop. > > It appears the intent of the loop was to print the names of the > subnodes under "/configurations". We would need the offset to the > "/configurations" node, which is abstracted by fit_find_config_node(). > > This change agrees that abstracting the node offset is the correct > design, and we shouldn't be parsing the configurations manually. Thus > the loop in spl_fit_get_image_name() is useless. Remove it. > > Signed-off-by: Alexandru Gagniuc > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: