public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Behun <marek.behun@nic.cz>
To: u-boot@lists.denx.de
Subject: [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with OF path and device name in get_mtd_device_nm()
Date: Thu, 25 Feb 2021 21:07:40 +0100	[thread overview]
Message-ID: <20210225210740.3ae53825@nic.cz> (raw)
In-Reply-To: <CAPnjgZ3dUsxVtiR3upZQjU9_iKk3OYUUEnJfv4u7nZD4xi=wnQ@mail.gmail.com>

On Thu, 25 Feb 2021 14:31:42 -0500
Simon Glass <sjg@chromium.org> wrote:

> We should not need CONFIG_DM here...it should be enabled for all
> boards. You can always disable MTD for a board if not, or send a
> removable patch.
> 
> If for some reason you do, please use if (IS_ENABLED() so that 'dev'
> can always be declared.

Simon, it still isn't enabled for all boards. For example
tqma6s_wru4_mmc_defconfig does not compile with this. I actually wrote
this into commit message:

  Although CONFIG_DM is compulsory since v2020.01, there are still some
  boards (for example tqma6s_wru4_mmc_defconfig) that don't enable it. 

But if breaking such boards is not a problem anymore, I will gladly
just remove the ifdefs :) Should I?

Marek

  reply	other threads:[~2021-02-25 20:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 14:13 [PATCH u-boot-dm + u-boot-spi v3 00/11] Support SPI NORs and OF partitions in `mtd list` Marek Behún
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 01/11] dm: core: add test for ofnode_get_addr_size_index() Marek Behún
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 02/11] dm: core: add non-translating version of ofnode_get_addr_size_index() Marek Behún
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 03/11] dm: core: add ofnode_get_path() Marek Behún
2021-02-25 19:31   ` Simon Glass
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 04/11] mtd: add support for parsing partitions defined in OF Marek Behún
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 05/11] mtd: spi-nor: allow registering multiple MTDs when DM is enabled Marek Behún
2021-02-25 15:51   ` Miquel Raynal
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 06/11] mtd: spi-nor: fill-in mtd->dev member Marek Behún
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 07/11] mtd: remove mtd_probe() function Marek Behún
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 08/11] mtd: probe SPI NOR devices in mtd_probe_devices() Marek Behún
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 09/11] cmd: mtd: print device OF path in listing Marek Behún
2021-02-25 19:31   ` Simon Glass
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with OF path and device name in get_mtd_device_nm() Marek Behún
2021-02-25 19:31   ` Simon Glass
2021-02-25 20:07     ` Marek Behun [this message]
2021-02-25 20:28       ` Tom Rini
2021-02-25 20:35         ` Marek Behun
2021-02-25 20:39           ` Tom Rini
2021-03-01 14:03             ` Marek Behun
2021-03-01 14:33               ` Tom Rini
2021-02-25 14:13 ` [PATCH u-boot-dm + u-boot-spi v3 11/11] cmd: mtd: expand <name> argument definition in command help Marek Behún
2021-02-25 15:57 ` [PATCH u-boot-dm + u-boot-spi v3 00/11] Support SPI NORs and OF partitions in `mtd list` Miquel Raynal
2021-02-26 13:07 ` Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210225210740.3ae53825@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox