From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Behun <marek.behun@nic.cz>
Date: Thu, 25 Feb 2021 21:07:40 +0100
Subject: [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with
 OF path and device name in get_mtd_device_nm()
In-Reply-To: <CAPnjgZ3dUsxVtiR3upZQjU9_iKk3OYUUEnJfv4u7nZD4xi=wnQ@mail.gmail.com>
References: <20210225141336.6149-1-marek.behun@nic.cz>
 <20210225141336.6149-11-marek.behun@nic.cz>
 <CAPnjgZ3dUsxVtiR3upZQjU9_iKk3OYUUEnJfv4u7nZD4xi=wnQ@mail.gmail.com>
Message-ID: <20210225210740.3ae53825@nic.cz>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 25 Feb 2021 14:31:42 -0500
Simon Glass <sjg@chromium.org> wrote:

> We should not need CONFIG_DM here...it should be enabled for all
> boards. You can always disable MTD for a board if not, or send a
> removable patch.
> 
> If for some reason you do, please use if (IS_ENABLED() so that 'dev'
> can always be declared.

Simon, it still isn't enabled for all boards. For example
tqma6s_wru4_mmc_defconfig does not compile with this. I actually wrote
this into commit message:

  Although CONFIG_DM is compulsory since v2020.01, there are still some
  boards (for example tqma6s_wru4_mmc_defconfig) that don't enable it. 

But if breaking such boards is not a problem anymore, I will gladly
just remove the ifdefs :) Should I?

Marek