public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH v2 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable
Date: Sat, 27 Feb 2021 01:38:52 +0100	[thread overview]
Message-ID: <20210227003852.fxygitdkzmhwwgpq@pali> (raw)
In-Reply-To: <20210215195934.67034-3-luka.kovacic@sartura.hr>

On Monday 15 February 2021 20:59:33 Luka Kovacic wrote:
> Add the loadaddr U-Boot environment variable, as this is available in
> the stock Marvell U-Boot by default on Marvell Armada A37XX platforms.

Hello Luka! Why is this change needed? mvebu_armada-37xx.h already
defines CONFIG_SYS_LOAD_ADDR macro with its default value 0x06000000.
So defining loadaddr variable should not be needed at all. And it is
suspicious for me why definition is to the same default value.

> Signed-off-by: Luka Kovacic <luka.kovacic@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Robert Marko <robert.marko@sartura.hr>
> ---
>  include/configs/mvebu_armada-37xx.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h
> index 2ad4325eaf..1041df8d91 100644
> --- a/include/configs/mvebu_armada-37xx.h
> +++ b/include/configs/mvebu_armada-37xx.h
> @@ -103,6 +103,7 @@
>  
>  /* fdt_addr and kernel_addr are needed for existing distribution boot scripts */
>  #define CONFIG_EXTRA_ENV_SETTINGS	\
> +	"loadaddr=0x6000000\0"		\
>  	"scriptaddr=0x6d00000\0"	\
>  	"pxefile_addr_r=0x6e00000\0"	\
>  	"fdt_addr=0x6f00000\0"		\

  reply	other threads:[~2021-02-27  0:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 19:59 [PATCH v2 0/3] Add support for the GST ESPRESSOBin-Ultra board Luka Kovacic
2021-02-15 19:59 ` [PATCH v2 1/3] cmd: mvebu: Implement the Marvell hw_info command Luka Kovacic
2021-02-16  3:35   ` Tom Rini
2021-02-27  1:09   ` Pali Rohár
2021-02-28 21:54     ` Luka Kovacic
2021-03-01 15:17       ` Pali Rohár
2021-02-27 13:05   ` Marek Behun
2021-02-28 22:03     ` Luka Kovacic
2021-02-28 23:45     ` Heinrich Schuchardt
2021-02-15 19:59 ` [PATCH v2 2/3] arm: mvebu: mvebu_armada-37xx: Define the loadaddr environment variable Luka Kovacic
2021-02-27  0:38   ` Pali Rohár [this message]
2021-02-28 21:26     ` Luka Kovacic
2021-03-01 15:05       ` Pali Rohár
2021-02-15 19:59 ` [PATCH v2 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra board support Luka Kovacic
2021-02-27  0:48   ` Pali Rohár
2021-02-27 13:24   ` Marek Behun
2021-02-28 21:38     ` Luka Kovacic
2021-03-01 15:41       ` Pali Rohár
2021-03-01 17:13         ` Marek Behun
2021-03-01 17:14         ` Marek Behun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210227003852.fxygitdkzmhwwgpq@pali \
    --to=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox