From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH V2] ARM: imx: Include u-boot.img in u-boot-with-spl.imx if OF_SEPARATE=y
Date: Mon, 1 Mar 2021 12:56:57 -0500 [thread overview]
Message-ID: <20210301175657.GF10169@bill-the-cat> (raw)
In-Reply-To: <2f08deff-d957-5934-c69f-f314830f396f@denx.de>
On Mon, Mar 01, 2021 at 02:44:13PM +0100, Stefano Babic wrote:
> On 01.03.21 14:40, Stefano Babic wrote:
> > On 01.03.21 14:36, Marek Vasut wrote:
> > > On 3/1/21 10:27 AM, Stefano Babic wrote:
> > > > Hi Marek,
> > >
> > > Hi,
> > >
> > > [...]
> > >
> > > > > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> > > > > index 1aa26a50ad8..e6b4654cd35 100644
> > > > > --- a/arch/arm/mach-imx/Makefile
> > > > > +++ b/arch/arm/mach-imx/Makefile
> > > > > @@ -202,10 +202,10 @@ append = cat $(filter-out $< $(PHONY), $^) >> $@
> > > > > ? quiet_cmd_pad_cat = CAT???? $@
> > > > > ? cmd_pad_cat = $(cmd_objcopy) && $(append) || rm -f $@
> > > > > -u-boot-with-spl.imx: SPL u-boot.uim FORCE
> > > > > +u-boot-with-spl.imx: SPL $(if
> > > > > $(CONFIG_OF_SEPARATE),u-boot.img,u-boot.uim) FORCE
> > > > > ????? $(call if_changed,pad_cat)
> > > > > -u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx u-boot.uim FORCE
> > > > > +u-boot-with-nand-spl.imx: spl/u-boot-nand-spl.imx $(if
> > > > > $(CONFIG_OF_SEPARATE),u-boot.img,u-boot.uim) FORCE
> > > > > ????? $(call if_changed,pad_cat)
> > > > > ? quiet_cmd_u-boot-nand-spl_imx = GEN???? $@
> > > > >
> > > >
> > > > This patch breaks build for two boards, udoo and ot1200_spl.
> > > > Strange enough, I get weird results with git bisect (but
> > > > definetely this is the only patch I am applying that cause the
> > > > issue).
> > > >
> > > > Could you take a look, please ?
> > >
> > > There is V3 already, does that work?
> > > [PATCH V3] ARM: imx: Include u-boot.img in u-boot-with-spl.imx if
> > > OF_SEPARATE=y
> >
> > I pick it up and let you know, thanks.
> >
>
> Sorry, I answered to V2 thread, but I had already picked up V3, and this
> causes the issue with udoo and ot1200_spl.
Please note that ot1200 has today been ack'd for removal and udoo is on
the removal list:
https://patchwork.ozlabs.org/project/uboot/patch/20210221010634.21310-24-trini at konsulko.com/
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210301/ef6138d5/attachment.sig>
next prev parent reply other threads:[~2021-03-01 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 20:07 [PATCH V2] ARM: imx: Include u-boot.img in u-boot-with-spl.imx if OF_SEPARATE=y Marek Vasut
2021-02-02 10:48 ` Christoph Niedermaier
2021-03-01 9:27 ` Stefano Babic
2021-03-01 13:36 ` Marek Vasut
2021-03-01 13:40 ` Stefano Babic
2021-03-01 13:44 ` Stefano Babic
2021-03-01 15:41 ` Marek Vasut
2021-03-01 17:56 ` Tom Rini [this message]
2021-03-01 18:43 ` Marek Vasut
2021-03-01 19:28 ` Peter Robinson
2021-03-01 19:42 ` Tom Rini
2021-03-01 20:21 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301175657.GF10169@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox