* [BUG] segmentation fault in efi_firmware_fit_get_image_info()
@ 2021-03-02 19:14 Heinrich Schuchardt
2021-03-03 0:48 ` AKASHI Takahiro
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2021-03-02 19:14 UTC (permalink / raw)
To: u-boot
Hello Takahiro,
Jose's ESRT implementation calls efi_firmware_fit_get_image_info()
multiple times. This results in a segmentation fault in the depths of
dfu_free_entities() involving device_chld_remove().
I used
env set dfu_alt_info "sf 0:0=u-boot-bin raw 0x100000 0x50000;u-boot-env
raw 0x150000 0x200000"
for testing on sandbox_defconfig.
If I comment out the dfu_free_entities() calls the segmentation fault is
avoided.
Could you, please, check with Lukasz when and if you should call
dfu_free_entities() in efi_get_dfu_info().
Best regards
Heinrich
^ permalink raw reply [flat|nested] 2+ messages in thread
* [BUG] segmentation fault in efi_firmware_fit_get_image_info()
2021-03-02 19:14 [BUG] segmentation fault in efi_firmware_fit_get_image_info() Heinrich Schuchardt
@ 2021-03-03 0:48 ` AKASHI Takahiro
0 siblings, 0 replies; 2+ messages in thread
From: AKASHI Takahiro @ 2021-03-03 0:48 UTC (permalink / raw)
To: u-boot
Lukasz,
On Tue, Mar 02, 2021 at 08:14:46PM +0100, Heinrich Schuchardt wrote:
> Hello Takahiro,
>
> Jose's ESRT implementation calls efi_firmware_fit_get_image_info()
> multiple times. This results in a segmentation fault in the depths of
> dfu_free_entities() involving device_chld_remove().
>
> I used
>
> env set dfu_alt_info "sf 0:0=u-boot-bin raw 0x100000 0x50000;u-boot-env
> raw 0x150000 0x200000"
>
> for testing on sandbox_defconfig.
>
> If I comment out the dfu_free_entities() calls the segmentation fault is
> avoided.
>
> Could you, please, check with Lukasz when and if you should call
> dfu_free_entities() in efi_get_dfu_info().
I'm not sure yet, but dfu_init_env_entities() and dfu_free_entities()
are always paired in get_image_info() as in other use cases like
dfu and thordown commands.
-Takahiro Akashi
> Best regards
>
> Heinrich
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-03 0:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-02 19:14 [BUG] segmentation fault in efi_firmware_fit_get_image_info() Heinrich Schuchardt
2021-03-03 0:48 ` AKASHI Takahiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox