From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [RFC PATCH u-boot 05/12] binman: declare symbols externally visible
Date: Wed, 3 Mar 2021 19:37:09 -0500 [thread overview]
Message-ID: <20210304003709.GS1310@bill-the-cat> (raw)
In-Reply-To: <20210303041211.26945-6-marek.behun@nic.cz>
On Wed, Mar 03, 2021 at 05:12:04AM +0100, Marek Beh?n wrote:
> Use the `__visible` macro to declare binman symbols externally visible,
> so that when building with LTO the compiler does not optimize this data
> away.
>
> Signed-off-by: Marek Beh?n <marek.behun@nic.cz>
> ---
> include/binman.h | 1 +
> include/binman_sym.h | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/binman.h b/include/binman.h
> index 5958dfb448..e72e85d4b7 100644
> --- a/include/binman.h
> +++ b/include/binman.h
> @@ -9,6 +9,7 @@
> #ifndef _BINMAN_H_
> #define _BINMAN_H_
>
> +#include <linux/compiler.h>
> #include <dm/ofnode.h>
>
> /**
> diff --git a/include/binman_sym.h b/include/binman_sym.h
> index 72e6765fe5..55421f5893 100644
> --- a/include/binman_sym.h
> +++ b/include/binman_sym.h
> @@ -33,7 +33,7 @@
> * @_prop_name: Property value to get from that entry (e.g. 'pos')
> */
> #define binman_sym_declare(_type, _entry_name, _prop_name) \
> - _type binman_symname(_entry_name, _prop_name) \
> + _type binman_symname(_entry_name, _prop_name) __visible \
> __attribute__((aligned(4), unused, section(".binman_sym")))
>
> /**
> @@ -58,7 +58,7 @@
> * @_prop_name: Property value to get from that entry (e.g. 'pos')
> */
> #define binman_sym_declare_optional(_type, _entry_name, _prop_name) \
> - _type binman_symname(_entry_name, _prop_name) \
> + _type binman_symname(_entry_name, _prop_name) __visible \
> __attribute__((aligned(4), weak, unused, \
> section(".binman_sym")))
I see failure to run test suites:
https://source.denx.de/u-boot/u-boot/-/jobs/232926
and adding <linux/compiler.h> to binman_sym.h leads to the same problem.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210303/12a0809c/attachment.sig>
next prev parent reply other threads:[~2021-03-04 0:37 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 4:11 [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51) Marek Behún
2021-03-03 4:12 ` [RFC PATCH u-boot 01/12] build: use thin archives instead of incremental linking Marek Behún
2021-03-04 10:57 ` Bin Meng
2021-03-04 18:17 ` Marek Behun
2021-03-05 13:34 ` Bin Meng
2021-03-05 13:37 ` Tom Rini
2021-03-06 21:20 ` Marek Behun
2021-03-05 15:39 ` Marek Behun
2021-03-03 4:12 ` [RFC PATCH u-boot 02/12] sandbox: errno: avoid conflict with libc's errno Marek Behún
2021-03-05 3:00 ` Bin Meng
2021-03-05 15:37 ` Marek Behun
2021-03-05 16:39 ` Simon Glass
2021-03-05 16:50 ` Marek Behun
2021-03-05 16:58 ` Simon Glass
2021-03-05 17:24 ` Heinrich Schuchardt
2021-03-05 17:24 ` Marek Behun
2021-03-05 19:42 ` Simon Glass
2021-03-05 17:21 ` Heinrich Schuchardt
2021-03-07 3:14 ` Marek Behun
2021-03-12 4:45 ` Simon Glass
2021-03-03 4:12 ` [RFC PATCH u-boot 03/12] linker_lists: declare entries and lists externally visible Marek Behún
2021-03-04 13:47 ` Marek Behun
2021-03-05 3:04 ` Bin Meng
2021-03-05 15:49 ` Marek Behun
2021-03-03 4:12 ` [RFC PATCH u-boot 04/12] efi_loader: fix warning when linking with LTO Marek Behún
2021-03-05 5:50 ` Bin Meng
2021-03-03 4:12 ` [RFC PATCH u-boot 05/12] binman: declare symbols externally visible Marek Behún
2021-03-04 0:37 ` Tom Rini [this message]
2021-03-04 1:53 ` Marek Behun
2021-03-03 4:12 ` [RFC PATCH u-boot 06/12] build: support building with Link Time Optimizations Marek Behún
2021-03-05 6:34 ` Bin Meng
2021-03-03 4:12 ` [RFC PATCH u-boot 07/12] arch: sandbox: make LTO available Marek Behún
2021-03-03 4:12 ` [RFC PATCH u-boot 08/12] sandbox: build with LTO Marek Behún
2021-03-03 4:12 ` [RFC PATCH u-boot 09/12] ARM: make gd a function for LTO Marek Behún
2021-03-03 4:12 ` [RFC PATCH u-boot 10/12] string: make memcpy() visible to fix LTO linking errors Marek Behún
2021-03-03 4:12 ` [RFC PATCH u-boot 11/12] arch: ARM: make LTO available Marek Behún
2021-03-03 4:12 ` [RFC PATCH u-boot 12/12] Nokia RX-51: build with LTO Marek Behún
2021-03-03 16:11 ` [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51) Tom Rini
2021-03-03 16:41 ` Marek Behun
2021-03-03 16:47 ` Tom Rini
2021-03-03 21:36 ` Tom Rini
2021-03-04 0:40 ` Adam Ford
2021-03-04 7:07 ` [PATCH] arm: fix LTO build for some thumb-interwork cases Marek Behún
2021-03-04 10:43 ` [RFC PATCH u-boot 00/12] U-Boot LTO (Sandbox + ARM Nokia RX-51) Marek Behun
2021-03-04 13:46 ` Adam Ford
2021-03-04 13:50 ` Marek Behun
2021-03-04 13:59 ` Adam Ford
2021-03-04 14:58 ` Tom Rini
2021-03-04 15:07 ` Adam Ford
2021-03-04 15:37 ` Marek Behun
2021-03-04 16:18 ` Tom Rini
2021-03-04 15:59 ` Marek Behun
2021-03-04 22:18 ` Adam Ford
2021-03-04 22:33 ` Marek Behun
2021-03-05 11:25 ` Adam Ford
2021-03-05 12:31 ` Stefan Roese
2021-03-05 17:10 ` Adam Ford
2021-03-06 3:03 ` Adam Ford
2021-03-06 11:12 ` Adam Ford
2021-03-06 17:37 ` Marek Behun
2021-03-06 20:08 ` Tom Rini
2021-03-06 20:41 ` Pali Rohár
2021-03-06 20:54 ` Marek Behun
2021-03-06 21:00 ` Pali Rohár
2021-03-06 21:19 ` Marek Behun
2021-03-06 21:38 ` Pali Rohár
2021-03-06 21:49 ` Marek Behun
2021-03-07 3:45 ` Adam Ford
2021-03-07 4:06 ` Marek Behun
2021-05-09 14:14 ` Adam Ford
2021-05-09 18:44 ` Marek Behun
2021-05-10 16:28 ` Simon Glass
2021-05-13 9:22 ` Pali Rohár
2021-03-04 16:17 ` Tom Rini
2021-03-04 16:35 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304003709.GS1310@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox