From: Phil Sutter <phil@nwl.cc>
To: u-boot@lists.denx.de
Subject: [PATCH 3/5] board/Synology: Unify legacy kernel support
Date: Thu, 4 Mar 2021 14:11:50 +0100 [thread overview]
Message-ID: <20210304131150.GL22016@orbyte.nwl.cc> (raw)
In-Reply-To: <649febca-bc4a-8902-b08d-b44603165279@denx.de>
On Thu, Mar 04, 2021 at 02:03:58PM +0100, Stefan Roese wrote:
> On 03.03.21 01:55, Phil Sutter wrote:
> > Move the relevant bits from ds109.{c,h} into common/ and adjust the code
> > to fit both DS109 and DS414. Moreover:
> >
> > * Introduce syno_board_id() which translates CONFIG_MACH_TYPE into the
> > expected board ID tag value.
> >
> > * Properly initialize isusbhost, mac and mtu fields from env variables.
> >
> > * Set the right bootargs/bootcmd to correctly boot legacy kernel out of
> > the (DS414) box. Getting the ramdisk location right is a bit tedious.
> >
> > Cc: Walter Schweizer <swwa@users.sourceforge.net>
> > Signed-off-by: Phil Sutter <phil@nwl.cc>
> > ---
> > board/Synology/common/Makefile | 5 +++
> > board/Synology/common/legacy.c | 75 ++++++++++++++++++++++++++++++++++
> > board/Synology/common/legacy.h | 33 +++++++++++++++
> > board/Synology/ds109/ds109.c | 32 ---------------
> > board/Synology/ds109/ds109.h | 17 --------
> > configs/ds414_defconfig | 2 +-
> > include/configs/ds109.h | 3 +-
> > include/configs/ds414.h | 15 ++++++-
> > 8 files changed, 130 insertions(+), 52 deletions(-)
> > create mode 100644 board/Synology/common/Makefile
> > create mode 100644 board/Synology/common/legacy.c
> > create mode 100644 board/Synology/common/legacy.h
> >
> > diff --git a/board/Synology/common/Makefile b/board/Synology/common/Makefile
> > new file mode 100644
> > index 0000000000000..62354cc2e82e6
> > --- /dev/null
> > +++ b/board/Synology/common/Makefile
> > @@ -0,0 +1,5 @@
> > +# SPDX-License-Identifier: GPL-2.0+
> > +#
> > +# Copyright (C) 2021 Phil Sutter <phil@nwl.cc>
> > +
> > +obj-y += legacy.o
> > diff --git a/board/Synology/common/legacy.c b/board/Synology/common/legacy.c
> > new file mode 100644
> > index 0000000000000..678e7b6809168
> > --- /dev/null
> > +++ b/board/Synology/common/legacy.c
> > @@ -0,0 +1,75 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2021
> > + * Walter Schweizer <swwa@users.sourceforge.net>
> > + * Phil Sutter <phil@nwl.cc>
> > + */
> > +
> > +#include <common.h>
>
> Please don't include "common.h" any more. There is ongoing work to
> depricate this common header.
OK, I'll respin. Thanks for the heads-up!
Phil
next prev parent reply other threads:[~2021-03-04 13:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 0:55 [PATCH 0/5] Synology DS414 integration mini-review Phil Sutter
2021-03-03 0:55 ` [PATCH 1/5] ds414: Add a Kconfig defining some strings Phil Sutter
2021-03-04 13:00 ` Stefan Roese
2021-03-03 0:55 ` [PATCH 2/5] configs: ds414: Enable XHCI_PCI by default Phil Sutter
2021-03-04 13:00 ` Stefan Roese
2021-03-04 13:11 ` Phil Sutter
2021-03-05 20:03 ` [PATCH v2 " Phil Sutter
2021-03-06 8:15 ` Stefan Roese
2021-03-07 20:58 ` Phil Sutter
2021-03-08 6:34 ` Stefan Roese
2021-03-07 21:21 ` [PATCH v3 " Phil Sutter
2021-03-08 6:34 ` Stefan Roese
2021-03-03 0:55 ` [PATCH 3/5] board/Synology: Unify legacy kernel support Phil Sutter
2021-03-04 13:03 ` Stefan Roese
2021-03-04 13:11 ` Phil Sutter [this message]
2021-03-05 20:04 ` [PATCH v2 " Phil Sutter
2021-03-07 21:22 ` [PATCH v3 " Phil Sutter
2021-03-08 6:36 ` Stefan Roese
2021-03-03 0:55 ` [PATCH 4/5] ds414: Auto-populate env if appropriate Phil Sutter
2021-03-04 13:06 ` Stefan Roese
2021-03-04 13:20 ` Phil Sutter
2021-03-04 13:22 ` Stefan Roese
2021-03-05 20:05 ` [PATCH v2 " Phil Sutter
2021-03-03 0:55 ` [PATCH 5/5] ds414: Add sample u-boot update command Phil Sutter
2021-03-04 13:09 ` Stefan Roese
2021-03-04 13:28 ` Phil Sutter
2021-03-04 13:34 ` Stefan Roese
2021-03-04 13:56 ` Phil Sutter
2021-03-05 20:05 ` [PATCH v2 " Phil Sutter
2021-04-08 8:52 ` [PATCH 0/5] Synology DS414 integration mini-review Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304131150.GL22016@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox