From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Sutter Date: Thu, 4 Mar 2021 14:28:38 +0100 Subject: [PATCH 5/5] ds414: Add sample u-boot update command In-Reply-To: <66cd71c8-b6e0-855a-8913-66128f0259f7@denx.de> References: <20210303005526.15056-1-phil@nwl.cc> <20210303005526.15056-6-phil@nwl.cc> <66cd71c8-b6e0-855a-8913-66128f0259f7@denx.de> Message-ID: <20210304132838.GN22016@orbyte.nwl.cc> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote: > On 03.03.21 01:55, Phil Sutter wrote: > > Signed-off-by: Phil Sutter > > It's common practice to add some minimal text in the commit text, > even for simple patches. I should learn to put less meaningful subjects in those cases so I have an easier time finding something to write about in the description. Then again, your question indicates I just didn't think hard enough. [...] > > diff --git a/include/configs/ds414.h b/include/configs/ds414.h > > index a2248cf75ad72..c8b45066cc75a 100644 > > --- a/include/configs/ds414.h > > +++ b/include/configs/ds414.h > > @@ -88,7 +88,12 @@ > > "initrd_high=0xffffffff\0" \ > > "ramdisk_addr_r=0x8000000\0" \ > > "usb0Mode=host\0usb1Mode=host\0usb2Mode=device\0" \ > > - "ethmtu=1500\0eth1mtu=1500\0" > > + "ethmtu=1500\0eth1mtu=1500\0" \ > > + "update_uboot=sf probe; dhcp; " \ > > + "mw.b ${loadaddr} 0x0 0xd0000; " \ > > + "tftpboot ${loadaddr} u-boot-spl.kwb; " \ > > + "sf update ${loadaddr} 0x0 0xd0000\0" > > + > > Wouldn't it be better to use ${filesize} instead of 0xd0000 here? U-Boot's "partition" size is fixed and hard-coded in the DTB at least. Putting the destination size as a limit at least avoids the unlikely chance of overwriting data past that partition. BTW: I spent a while trying to make the DTB-defined partitions available in sf command, but eventually gave up. Seems I need to have this SPI->MTD mapping and still define partitions in environment. Not worth spending cycles on though, I was just curious because 'help sf' mentions partitions as offset alternatives. Cheers, Phil