From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: u-boot@lists.denx.de
Subject: [patch v4 6/9] rockchip: pwm: Fix default polarity
Date: Fri, 05 Mar 2021 11:27:51 +0100 [thread overview]
Message-ID: <20210305103307.290295328@rtp-net.org> (raw)
In-Reply-To: 20210305102745.078091129@rtp-net.org
In the code, the default polarity is set to positive/positive,
which is neither normal polarity or inverted polarity. It's
only the hardware default. This leads to booting linux with
wrong polarity setting.
Update the code to use PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE
by default instead.
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Index: u-boot/drivers/pwm/rk_pwm.c
===================================================================
--- u-boot.orig/drivers/pwm/rk_pwm.c
+++ u-boot/drivers/pwm/rk_pwm.c
@@ -147,7 +147,7 @@ static int rk_pwm_probe(struct udevice *
priv->data = (struct rockchip_pwm_data *)dev_get_driver_data(dev);
if (priv->data->supports_polarity)
- priv->conf_polarity = PWM_DUTY_POSTIVE | PWM_INACTIVE_POSTIVE;
+ priv->conf_polarity = PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE;
return 0;
}
next prev parent reply other threads:[~2021-03-05 10:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 10:27 [patch v4 0/9] rk3399 (Pinebook pro) EDP support Arnaud Patard
2021-03-05 10:27 ` [patch v4 1/9] rockchip: video: vop: Use endpoint compatible string to find VOP mode Arnaud Patard
2021-03-05 10:27 ` [patch v4 2/9] rockchip: video: edp: Add rk3399 support Arnaud Patard
2021-03-05 10:27 ` [patch v4 3/9] Rockchip: video: edp: Change interrupt polarity configuration Arnaud Patard
2021-03-05 10:27 ` [patch v4 4/9] Rockchip: video: vop: Reserve efi fb memory Arnaud Patard
2021-03-05 10:27 ` [patch v4 5/9] rockchip: Pinebook Pro: Enable edp Arnaud Patard
2021-03-05 10:27 ` Arnaud Patard [this message]
2021-03-05 10:27 ` [patch v4 7/9] rockchip: video: vop: Fix format of fbbase in debug string Arnaud Patard
2021-03-05 10:27 ` [patch v4 8/9] rockchip: video: edp: Add missing reset support Arnaud Patard
2021-03-05 10:27 ` [patch v4 9/9] rockchip: video: vop: Add " Arnaud Patard
2021-04-11 19:20 ` [patch v4 0/9] rk3399 (Pinebook pro) EDP support Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305103307.290295328@rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox