From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 10/19] video: sunxi: dw-hdmi: probe driver by compatible
Date: Sun, 7 Mar 2021 01:33:06 +0000 [thread overview]
Message-ID: <20210307013306.58a1dd53@slackpad.fritz.box> (raw)
In-Reply-To: <20210306195437.9740-11-jernej.skrabec@siol.net>
On Sat, 6 Mar 2021 20:54:28 +0100
Jernej Skrabec <jernej.skrabec@siol.net> wrote:
> Currently sunxi dw-hdmi driver is probed unconditionally, even if there
> is no such device.
>
> Switch driver to probing via compatible string. This brings many
> benefits - driver can read DT node and allows driver to be always
> enabled.
Confirmed that this the one compatible string that all supported SoCs
use.
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Thanks!
Andre
> ---
> drivers/video/sunxi/sunxi_dw_hdmi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/sunxi/sunxi_dw_hdmi.c b/drivers/video/sunxi/sunxi_dw_hdmi.c
> index 6d2bc206fc2c..6f77b2a43b40 100644
> --- a/drivers/video/sunxi/sunxi_dw_hdmi.c
> +++ b/drivers/video/sunxi/sunxi_dw_hdmi.c
> @@ -372,14 +372,16 @@ static const struct dm_display_ops sunxi_dw_hdmi_ops = {
> .mode_valid = sunxi_dw_hdmi_mode_valid,
> };
>
> +static const struct udevice_id sunxi_dw_hdmi_ids[] = {
> + { .compatible = "allwinner,sun8i-a83t-dw-hdmi" },
> + { }
> +};
> +
> U_BOOT_DRIVER(sunxi_dw_hdmi) = {
> .name = "sunxi_dw_hdmi",
> .id = UCLASS_DISPLAY,
> + .of_match = sunxi_dw_hdmi_ids,
> .ops = &sunxi_dw_hdmi_ops,
> .probe = sunxi_dw_hdmi_probe,
> .priv_auto = sizeof(struct sunxi_dw_hdmi_priv),
> };
> -
> -U_BOOT_DRVINFO(sunxi_dw_hdmi) = {
> - .name = "sunxi_dw_hdmi"
> -};
next prev parent reply other threads:[~2021-03-07 1:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 19:54 [PATCH v2 00/19] video: sunxi: rework DE2 driver Jernej Skrabec
2021-03-06 19:54 ` [PATCH v2 01/19] sunxi: video: select dw-hdmi in Kconfig, not Makefile Jernej Skrabec
2021-03-06 19:54 ` [PATCH v2 02/19] video: sunxi: Add mode_valid callback to sunxi_dw_hdmi Jernej Skrabec
2021-03-06 19:54 ` [PATCH v2 03/19] common: edid: check for digital display earlier Jernej Skrabec
2021-03-06 19:54 ` [PATCH v2 04/19] common: edid: extract code for detailed timing search Jernej Skrabec
2021-03-07 1:29 ` Andre Przywara
2021-03-06 19:54 ` [PATCH v2 05/19] common: edid: Search for valid timing in extension block Jernej Skrabec
2021-03-06 19:54 ` [PATCH v2 06/19] video: sunxi: Use DW-HDMI hpd function Jernej Skrabec
2021-03-07 1:30 ` Andre Przywara
2021-03-06 19:54 ` [PATCH v2 07/19] video: sunxi: Remove check for ddc-i2c-bus property Jernej Skrabec
2021-03-06 19:54 ` [PATCH v2 08/19] video: sunxi: Remove TV probe from DE2 Jernej Skrabec
2021-03-07 1:31 ` Andre Przywara
2021-03-06 19:54 ` [PATCH v2 09/19] video: sunxi: de2: switch to public uclass functions Jernej Skrabec
2021-03-07 1:32 ` Andre Przywara
2021-03-07 7:35 ` Jernej Škrabec
2021-03-09 0:40 ` Andre Przywara
2021-03-09 5:35 ` Jernej Škrabec
2021-03-06 19:54 ` [PATCH v2 10/19] video: sunxi: dw-hdmi: probe driver by compatible Jernej Skrabec
2021-03-07 1:33 ` Andre Przywara [this message]
2021-03-06 19:54 ` [PATCH v2 11/19] video: sunxi: dw-hdmi: read address from DT node Jernej Skrabec
2021-04-06 1:09 ` Andre Przywara
2021-03-06 19:54 ` [PATCH v2 12/19] video: sunxi: de2: switch to DT probing Jernej Skrabec
2021-04-06 1:09 ` Andre Przywara
2021-04-06 7:14 ` Simon Glass
2021-03-06 19:54 ` [PATCH v2 13/19] video: sunxi: de2: read address from DT node Jernej Skrabec
2021-04-06 1:10 ` Andre Przywara
2021-03-06 19:54 ` [PATCH v2 14/19] clk: sunxi: Add DE2 and HDMI clocks to H3 and A64 Jernej Skrabec
2021-03-08 8:00 ` Jagan Teki
2021-03-06 19:54 ` [PATCH v2 15/19] clk: sunxi: add DE2 clock driver Jernej Skrabec
2021-03-08 7:59 ` Jagan Teki
2021-03-06 19:54 ` [PATCH v2 16/19] video: sunxi: de2: switch clock setup to DM model Jernej Skrabec
2021-03-08 8:02 ` Jagan Teki
2021-03-06 19:54 ` [PATCH v2 17/19] video: dw-hdmi: modify phy init callback to include full timings Jernej Skrabec
2021-03-06 19:54 ` [PATCH v2 18/19] video: sunxi: Add DW HDMI PHY driver Jernej Skrabec
2021-03-08 7:57 ` Jagan Teki
2021-03-09 5:38 ` Jernej Škrabec
2021-03-06 19:54 ` [PATCH v2 19/19] video: sunxi: dw-hdmi: Use new " Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307013306.58a1dd53@slackpad.fritz.box \
--to=andre.przywara@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox