From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Sun, 7 Mar 2021 05:58:00 +0100 Subject: [PATCH u-boot 14/39] lib: crc32: make the crc_table variable non-const In-Reply-To: <042b7e3b-511a-c822-dfbd-fe66aa5faa55@denx.de> References: <20210307042538.21229-1-marek.behun@nic.cz> <20210307042538.21229-15-marek.behun@nic.cz> <042b7e3b-511a-c822-dfbd-fe66aa5faa55@denx.de> Message-ID: <20210307055800.3fa65244@nic.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 7 Mar 2021 05:46:24 +0100 Marek Vasut wrote: > On 3/7/21 5:25 AM, Marek Beh?n wrote: > > When compiling with LTO, the compiler fails with an error saying that > > `crc_table` causes a section type conflict with `efi_var_buf`. > > > > This is because both are declared to be in the same section (via macro > > `__efi_runtime_data`), but one is const while the other is not. > > > > Make this variable non-const in order to fix this. > > This does not look right, the crc32 array is constant. > Maybe what you want to do instead if create some __efi_constant_data > section ? Yes, this was the easier solution, and maybe is not ideal. I thought it would not be much of a problem since this array can be nonconstant (generated after boot) if CONFIG_DYNAMIC_CRC_TABLE is enabled. Anyway I don't much understand the EFI code so I wanted to poke into it as little as possible. Marek