public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] ahci: mediatek: fix undefined reference of dev_err
@ 2021-03-16 18:05 Frank Wunderlich
  2021-03-19 20:42 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Frank Wunderlich @ 2021-03-16 18:05 UTC (permalink / raw)
  To: u-boot

From: Frank Wunderlich <frank-w@public-files.de>

building with MTK_AHCI enabled results in implicit declaration and
undefined reference of dev_err followed by a segfault of gcc

drivers/ata/mtk_ahci.c: In function 'mtk_ahci_parse_property':
drivers/ata/mtk_ahci.c:65:4: warning:
implicit declaration of function 'dev_err'
drivers/ata/mtk_ahci.c:65: undefined reference to `dev_err'
in function `mtk_ahci_probe':
drivers/ata/mtk_ahci.c:92: undefined reference to `dev_err'
Segmentation fault

fix this by adding the dm/device_compat.h to includes

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 drivers/ata/mtk_ahci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/mtk_ahci.c b/drivers/ata/mtk_ahci.c
index 554175bc0051..2c5227df306b 100644
--- a/drivers/ata/mtk_ahci.c
+++ b/drivers/ata/mtk_ahci.c
@@ -21,6 +21,7 @@
 #include <sata.h>
 #include <scsi.h>
 #include <syscon.h>
+#include <dm/device_compat.h>
 
 #define SYS_CFG			0x14
 #define SYS_CFG_SATA_MSK	GENMASK(31, 30)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ahci: mediatek: fix undefined reference of dev_err
  2021-03-16 18:05 [PATCH] ahci: mediatek: fix undefined reference of dev_err Frank Wunderlich
@ 2021-03-19 20:42 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2021-03-19 20:42 UTC (permalink / raw)
  To: u-boot

On Tue, Mar 16, 2021 at 07:05:33PM +0100, Frank Wunderlich wrote:

> From: Frank Wunderlich <frank-w@public-files.de>
> 
> building with MTK_AHCI enabled results in implicit declaration and
> undefined reference of dev_err followed by a segfault of gcc
> 
> drivers/ata/mtk_ahci.c: In function 'mtk_ahci_parse_property':
> drivers/ata/mtk_ahci.c:65:4: warning:
> implicit declaration of function 'dev_err'
> drivers/ata/mtk_ahci.c:65: undefined reference to `dev_err'
> in function `mtk_ahci_probe':
> drivers/ata/mtk_ahci.c:92: undefined reference to `dev_err'
> Segmentation fault
> 
> fix this by adding the dm/device_compat.h to includes
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210319/efe0a0d1/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-19 20:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-16 18:05 [PATCH] ahci: mediatek: fix undefined reference of dev_err Frank Wunderlich
2021-03-19 20:42 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox