From: Alexandru Gagniuc <mr.nuke.me@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/3] configs: stm32mp1: Remove misleading CONFIG_SPL_BSS_START_ADDR
Date: Mon, 22 Mar 2021 08:20:00 -0500 [thread overview]
Message-ID: <20210322132001.1637567-2-mr.nuke.me@gmail.com> (raw)
In-Reply-To: <20210322132001.1637567-1-mr.nuke.me@gmail.com>
CONFIG_SPL_BSS_START_ADDR is only used on a few mach- linker scripts.
stm32mp1 uses the generic script under arch/arm/cpu/u-boot-spl.lds,
which does not make use of this definition.
The SPL BSS starts in SRAM, right after .text, .rodata, .data, and
.u_boot_list. A very short version of the STM32MP1 memory map is:
* SYSRAM: 2ffc0000 - 30000000 <- all of SPL is here
* DRAM: c0000000+
0xC0200000 is a DRAM address, and has nothing to do with SPL. It is
just very misleading to have it next to CONFIG_SPL_BSS_MAX_SIZE, or to
have it at all.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
include/configs/stm32mp1.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h
index 7fdb3ffce4..56a70cb584 100644
--- a/include/configs/stm32mp1.h
+++ b/include/configs/stm32mp1.h
@@ -50,7 +50,6 @@
/* SPL support */
#ifdef CONFIG_SPL
/* SPL use DDR */
-#define CONFIG_SPL_BSS_START_ADDR 0xC0200000
#define CONFIG_SPL_BSS_MAX_SIZE 0x00100000
#define CONFIG_SYS_SPL_MALLOC_START 0xC0300000
#define CONFIG_SYS_SPL_MALLOC_SIZE 0x01D00000
--
2.26.2
next prev parent reply other threads:[~2021-03-22 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 13:19 [PATCH 1/3] configs: stm32mp1: stm32mp1: Increase SPL malloc() size Alexandru Gagniuc
2021-03-22 13:20 ` Alexandru Gagniuc [this message]
2021-03-26 15:13 ` [PATCH 2/3] configs: stm32mp1: Remove misleading CONFIG_SPL_BSS_START_ADDR Patrice CHOTARD
2021-04-07 9:22 ` Patrick DELAUNAY
2021-04-09 9:59 ` Patrice CHOTARD
2021-03-22 13:20 ` [PATCH 3/3] configs: stm32mp1: Fix misleading SPL size limitations Alexandru Gagniuc
2021-03-26 15:14 ` Patrice CHOTARD
2021-04-07 9:12 ` Patrick DELAUNAY
2021-04-09 9:59 ` Patrice CHOTARD
2021-03-26 15:12 ` [PATCH 1/3] configs: stm32mp1: stm32mp1: Increase SPL malloc() size Patrice CHOTARD
2021-04-07 9:23 ` Patrick DELAUNAY
2021-04-09 9:59 ` Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322132001.1637567-2-mr.nuke.me@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox