public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 2/2] test: unit test for longjmp
Date: Fri, 26 Mar 2021 09:45:58 +0800	[thread overview]
Message-ID: <20210326014545.GA23068@andestech.com> (raw)
In-Reply-To: <20210325073150.12934-3-xypron.glpk@gmx.de>

On Thu, Mar 25, 2021 at 03:31:50PM +0800, Heinrich Schuchardt wrote:
> Provide a unit test for the longjmp() library function
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ----
> v4:
> 	use volatile for variable changed between setjmp and longjmp
> v3:
> 	check variable on stack
> v2:
> 	no change
> ---
>  test/lib/Makefile  |  1 +
>  test/lib/longjmp.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 78 insertions(+)
>  create mode 100644 test/lib/longjmp.c
> 
> diff --git a/test/lib/Makefile b/test/lib/Makefile
> index 97c11e35a8..a30f615aa9 100644
> --- a/test/lib/Makefile
> +++ b/test/lib/Makefile
> @@ -7,6 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o
>  obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o
>  obj-y += hexdump.o
>  obj-y += lmb.o
> +obj-y += longjmp.o
>  obj-$(CONFIG_CONSOLE_RECORD) += test_print.o
>  obj-$(CONFIG_SSCANF) += sscanf.o
>  obj-y += string.o
> diff --git a/test/lib/longjmp.c b/test/lib/longjmp.c
> new file mode 100644
> index 0000000000..bd1fe1aff6
> --- /dev/null
> +++ b/test/lib/longjmp.c
> @@ -0,0 +1,77 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Test setjmp(), longjmp()
> + *
> + * Copyright (c) 2021, Heinrich Schuchardt <xypron.glpk@gmx.de>
> + */
> +
> +#include <common.h>
> +#include <test/lib.h>
> +#include <test/test.h>
> +#include <test/ut.h>
> +#include <asm/setjmp.h>
> +
> +struct test_jmp_buf {
> +	jmp_buf env;
> +	/*
> +	 * Auto-variables changed between setjmp() and longjmp() must be
> +	 * static or volatile. Otherwise the result is undefined.
> +	 */
> +	volatile int val;
> +};
> +
> +/**
> + * test_longjmp() - test longjmp function
> + *
> + * @i is passed to longjmp.
> + * @i << 8 is set in the environment structure.
> + *
> + * @env:	environment
> + * @i:		value passed to longjmp()
> + */
> +static void noinline test_longjmp(struct test_jmp_buf *env, int i)
> +{
> +	env->val = i << 8;
> +	longjmp(env->env, i);
> +}
> +
> +/**
> + * test_setjmp() - test setjmp function
> + *
> + * setjmp() will return the value @i passed to longjmp() if @i is non-zero.
> + * For @i == 0 we expect return value 1.
> + *
> + * @i << 8 will be set by test_longjmp in the environment structure.
> + * This value can be used to check that the stack frame is restored.
> + *
> + * We return the XORed values to allow simply check both at once.
> + *
> + * @i:		value passed to longjmp()
> + * Return:	values return by longjmp()
> + */
> +static int test_setjmp(int i)
> +{
> +	struct test_jmp_buf env;
> +	int ret;
> +
> +	env.val = -1;
> +	ret = setjmp(env.env);
> +	if (ret)
> +		return ret ^ env.val;
> +	test_longjmp(&env, i);
> +	/* We should not arrive here */
> +	return 0x1000;
> +}
> +
> +static int lib_test_longjmp(struct unit_test_state *uts)
> +{
> +	int i;
> +
> +	for (i = -3; i < 0; ++i)
> +		ut_asserteq(i ^ (i << 8) , test_setjmp(i));
> +	ut_asserteq(1, test_setjmp(0));
> +	for (i = 1; i < 4; ++i)
> +		ut_asserteq(i ^ (i << 8), test_setjmp(i));
> +	return 0;
> +}
> +LIB_TEST(lib_test_longjmp, 0);
> --
> 2.30.2
> 

Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>

      reply	other threads:[~2021-03-26  1:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  7:31 [PATCH v4 0/2] riscv: simplify longjmp Heinrich Schuchardt
2021-03-25  7:31 ` [PATCH v4 1/2] " Heinrich Schuchardt
2021-03-25  7:31 ` [PATCH v4 2/2] test: unit test for longjmp Heinrich Schuchardt
2021-03-26  1:45   ` Leo Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326014545.GA23068@andestech.com \
    --to=ycliang@andestech.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox