From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Thu, 8 Apr 2021 21:35:36 +0200 Subject: [EXT] Re: [PATCH v1 2/5] net: phy: marvell: extend 88E2110 to use both 2.5GHz modes In-Reply-To: References: <20210324092008.1300548-1-sr@denx.de> <20210324101949.v1.2.I60e61534246755c890f5283d6041f9c8fbcea87b@changeid> <20210324104418.2ee37fee@thinkpad> <20210324114713.1f36e11a@thinkpad> <20210324145208.2559de68@thinkpad> <20210324234550.11a5e8a9@thinkpad> Message-ID: <20210408213536.56a4ae41@thinkpad> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 8 Apr 2021 19:18:09 +0000 Stefan Chulski wrote: > > > > Stefan, you suggest to drop this define from PHY_INTERFACE enum which we > > can't easily do with other drivers (like NXP) also referencing this macro. > > > > How to continue then? > > > > Thanks, > > Stefan > > Probably we should drop SGMII_2500 from this series, introduce "manage" devicetree property(that would indicate if inband supported or not). > For example this is armada-8040-mcbin.dtsi In kernel, when in-band supported: > &cp1_eth2 { > /* CPS Lane 5 */ > status = "okay"; > /* Network PHY */ > phy-mode = "2500base-x"; > managed = "in-band-status"; > /* Generic PHY, providing serdes lanes */ > phys = <&cp1_comphy5 2>; > sfp = <&sfp_eth3>; > }; > > If in-band not supported(for example PPv2 MAC connected to 88E2110 in 2.5G speed) we would use default managed = "auto" and fixed link property. Such DTS properties should first be proposed to device-tree ML and documented in devicetree bindings documentation. Marek