From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/3] fit: Use hash.c to call SHA code
Date: Mon, 12 Apr 2021 22:30:19 -0400 [thread overview]
Message-ID: <20210413023019.GD1310@bill-the-cat> (raw)
In-Reply-To: <20210217032042.425512-3-joel@jms.id.au>
On Wed, Feb 17, 2021 at 01:50:41PM +1030, Joel Stanley wrote:
> Currently the FIT hashing will call directly into the SHA algorithms to
> get a hash.
>
> This moves the fit code to use hash_lookup_algo, giving a common
> entrypoint into the hashing code and removing the duplicated algorithm
> look up. It also allows the use of hardware acceleration if configured.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
This breaks a few boards:
ls1046ardb_qspi_spl imx8mm_beacon imx8mn_beacon imx8mn_beacon_2g
imx8mm_evk imx8mn_ddr4_evk imx8mn_evk imx8mp_evk imx8mq_evk
imx8mm_venice imx8mq_phanbell phycore-imx8mm phycore-imx8mp pico-imx8mq
verdin-imx8mm mt8183_pumpkin mt8516_pumpkin
that use FIT images, in SPL, but don't actually check hashes apparently.
Just including hash.o for the hash-lookup function fails because we
don't have crc16, etc, enabled and also I think need:
https://patchwork.ozlabs.org/project/uboot/patch/20210322133331.1646575-1-mr.nuke.me at gmail.com/
for consistent symbol naming.
So, I like this patch in concept, but I think it'll need to be reworked
a bit, after I pull in some other changes soon. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210412/8e4c512e/attachment.sig>
next prev parent reply other threads:[~2021-04-13 2:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 3:20 [PATCH 0/3] Improvements to FIT hashing Joel Stanley
2021-02-17 3:20 ` [PATCH 1/3] hw_sha: Fix coding style errors Joel Stanley
2021-04-13 14:27 ` Tom Rini
2021-02-17 3:20 ` [PATCH 2/3] fit: Use hash.c to call SHA code Joel Stanley
2021-02-17 5:03 ` AKASHI Takahiro
2021-04-12 23:52 ` Joel Stanley
2021-04-13 2:30 ` Tom Rini [this message]
2021-02-17 3:20 ` [PATCH 3/3] hash: Allow for SHA512 hardware implementations Joel Stanley
2021-04-13 14:27 ` Tom Rini
2021-05-12 16:01 ` Heinrich Schuchardt
2021-05-12 16:05 ` Simon Glass
2021-05-12 16:19 ` Heinrich Schuchardt
2021-05-12 17:29 ` Ilias Apalodimas
2021-05-12 17:32 ` Simon Glass
2021-05-12 21:22 ` Heinrich Schuchardt
2021-05-13 14:36 ` Simon Glass
2021-05-13 15:33 ` Heinrich Schuchardt
2021-05-13 23:56 ` Simon Glass
2021-04-12 23:50 ` [PATCH 0/3] Improvements to FIT hashing Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413023019.GD1310@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox