From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 12 Apr 2021 22:30:19 -0400 Subject: [PATCH 2/3] fit: Use hash.c to call SHA code In-Reply-To: <20210217032042.425512-3-joel@jms.id.au> References: <20210217032042.425512-1-joel@jms.id.au> <20210217032042.425512-3-joel@jms.id.au> Message-ID: <20210413023019.GD1310@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 17, 2021 at 01:50:41PM +1030, Joel Stanley wrote: > Currently the FIT hashing will call directly into the SHA algorithms to > get a hash. > > This moves the fit code to use hash_lookup_algo, giving a common > entrypoint into the hashing code and removing the duplicated algorithm > look up. It also allows the use of hardware acceleration if configured. > > Signed-off-by: Joel Stanley This breaks a few boards: ls1046ardb_qspi_spl imx8mm_beacon imx8mn_beacon imx8mn_beacon_2g imx8mm_evk imx8mn_ddr4_evk imx8mn_evk imx8mp_evk imx8mq_evk imx8mm_venice imx8mq_phanbell phycore-imx8mm phycore-imx8mp pico-imx8mq verdin-imx8mm mt8183_pumpkin mt8516_pumpkin that use FIT images, in SPL, but don't actually check hashes apparently. Just including hash.o for the hash-lookup function fails because we don't have crc16, etc, enabled and also I think need: https://patchwork.ozlabs.org/project/uboot/patch/20210322133331.1646575-1-mr.nuke.me at gmail.com/ for consistent symbol naming. So, I like this patch in concept, but I think it'll need to be reworked a bit, after I pull in some other changes soon. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: