From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 16 Apr 2021 08:26:10 -0400 Subject: [PATCH v3 1/6] spl: LOAD_FIT_FULL: Fix selection of the "fdt" node In-Reply-To: <20210401182531.2147653-2-mr.nuke.me@gmail.com> References: <20210401182531.2147653-1-mr.nuke.me@gmail.com> <20210401182531.2147653-2-mr.nuke.me@gmail.com> Message-ID: <20210416122610.GC1310@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Apr 01, 2021 at 01:25:26PM -0500, Alexandru Gagniuc wrote: > The correct FDT to use is described by the "fdt" property of the > configuration node. When the fit_unamep argument to fit_image_load() > is "fdt", we get the "/images/fdt" node. This is incorrect, as it > ignores the "fdt" property of the config node, and in most cases, > the "/images/fdt" node doesn't exist. > > Use NULL for the 'fit_unamep' argument. With NULL, fit_image_load() > uses the IH_TYPE_FLATDT value to read the config property "fdt", > which points to the correct FDT node(s). > > fit_image_load() should probably be split into a function that reads > an image by name, and one that reads an image by config reference. I > don't make those decisions, I just point out the craziness. > > Signed-off-by: Alexandru Gagniuc > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: