From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] cmd: gpt: remove redundant print messages
Date: Mon, 19 Apr 2021 11:10:42 -0400 [thread overview]
Message-ID: <20210419151042.GA11918@bill-the-cat> (raw)
In-Reply-To: <1617214549-26153-1-git-send-email-rahasij@linux.microsoft.com>
On Wed, Mar 31, 2021 at 11:15:49AM -0700, Ravik Hasija wrote:
> Removing printfs from do_gpt API as the messages are generic and does not
> specify error codes for failure cases.
>
> Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> Changes for v2:
> - Updated usage message for gpt read
> - Added removed printfs for write & verify
> - Rearranged verify printf
This change in output breaks test_gpt_verify (see
test/py/tests/test_gpt.py) so that needs to be updated at the same time,
thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210419/022a784d/attachment.sig>
prev parent reply other threads:[~2021-04-19 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 21:34 [PATCH] cmd: gpt: remove redundant print messages Ravik Hasija
2021-03-31 8:46 ` Patrick DELAUNAY
2021-03-31 18:15 ` [PATCH v2] " Ravik Hasija
2021-04-19 15:10 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419151042.GA11918@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox