public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 4/4] configs: Enable USB3 on Allwinner H6 boards
Date: Wed, 21 Apr 2021 11:37:13 +0100	[thread overview]
Message-ID: <20210421113713.55fc6fa1@slackpad.fritz.box> (raw)
In-Reply-To: <20210417142059.45337-5-samuel@sholland.org>

On Sat, 17 Apr 2021 09:20:59 -0500
Samuel Holland <samuel@sholland.org> wrote:

> Pine H64 and Orange Pi 3 both provide a USB3 type A port.
> Enable it in U-Boot.

Any reason to enable it only for those two boards? Just because those
are the H6 devices you have access to?

I wonder if we should enable this in Kconfig for all H6 boards? Or at
least reduce the number of lines in defconfig, by adding select's in
Kconfig?

Also: this doesn't work out of the box for the Pine H64, right? Because
the official DT keeps the dwc3 and usb3phy nodes disabled.
I was planing on sending a DT fix to the kernel.

But with those nodes enabled it indeed works for me, and adds another
usable USB port to those H6 boards.

Cheers,
Andre

> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>  configs/orangepi_3_defconfig | 5 +++++
>  configs/pine_h64_defconfig   | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/configs/orangepi_3_defconfig b/configs/orangepi_3_defconfig
> index 82b9815205..eb25bd9f50 100644
> --- a/configs/orangepi_3_defconfig
> +++ b/configs/orangepi_3_defconfig
> @@ -8,5 +8,10 @@ CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>  CONFIG_BLUETOOTH_DT_DEVICE_FIXUP="brcm,bcm4345c5"
>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-orangepi-3"
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> +CONFIG_PHY_SUN50I_USB3=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_XHCI_DWC3=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_DWC3=y
> +# CONFIG_USB_DWC3_GADGET is not set
> diff --git a/configs/pine_h64_defconfig b/configs/pine_h64_defconfig
> index 2fa66f3834..0095fb222e 100644
> --- a/configs/pine_h64_defconfig
> +++ b/configs/pine_h64_defconfig
> @@ -12,5 +12,10 @@ CONFIG_SPL_SPI_SUNXI=y
>  CONFIG_DEFAULT_DEVICE_TREE="sun50i-h6-pine-h64"
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_SUN8I_EMAC=y
> +CONFIG_PHY_SUN50I_USB3=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_XHCI_DWC3=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_DWC3=y
> +# CONFIG_USB_DWC3_GADGET is not set

  reply	other threads:[~2021-04-21 10:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17 14:20 [PATCH v2 0/4] Allwinner H6 USB3 support Samuel Holland
2021-04-17 14:20 ` [PATCH v2 1/4] phy: sun50i-usb3: Add a driver for the H6 USB3 PHY Samuel Holland
2021-04-17 14:20 ` [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core Samuel Holland
2021-04-21 10:36   ` Andre Przywara
2021-04-21 13:36     ` Samuel Holland
2021-04-21 14:58       ` Andre Przywara
2021-07-05  8:04   ` Bin Meng
2021-07-05  8:19     ` Marek Vasut
2021-07-05  8:38       ` Bin Meng
2021-07-05  9:06         ` Andre Przywara
2021-07-05  9:18           ` Bin Meng
2021-07-05 10:45             ` Marek Vasut
2021-07-05 12:12               ` Andre Przywara
2021-07-05  9:20         ` Marek Vasut
2021-04-17 14:20 ` [PATCH v2 3/4] usb: xhci-dwc3: Add support for clocks/resets Samuel Holland
2021-04-21 10:37   ` Andre Przywara
2021-04-17 14:20 ` [PATCH v2 4/4] configs: Enable USB3 on Allwinner H6 boards Samuel Holland
2021-04-21 10:37   ` Andre Przywara [this message]
2021-04-21 10:43 ` [PATCH v2 0/4] Allwinner H6 USB3 support Andre Przywara
2021-04-21 10:53   ` Marek Vasut
2021-07-04 23:09     ` Andre Przywara
2021-07-05  1:18       ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210421113713.55fc6fa1@slackpad.fritz.box \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox