public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] imx: mkimage_fit_atf: fix file size reporting
@ 2021-04-07  4:04 Tim Harvey
  2021-05-02 11:42 ` stefano.babic at babic.homelinux.org
  0 siblings, 1 reply; 2+ messages in thread
From: Tim Harvey @ 2021-04-07  4:04 UTC (permalink / raw)
  To: u-boot

instead using ls and awk to determine file size use stat instead.
This fixes an invalid size reporting for user or group names that have
spaces in them.

This adds a dependency on the stat application which is part of
the coreutils package which also includes ls.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 arch/arm/mach-imx/mkimage_fit_atf.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-imx/mkimage_fit_atf.sh b/arch/arm/mach-imx/mkimage_fit_atf.sh
index fe12b7bb4b..2a17968794 100755
--- a/arch/arm/mach-imx/mkimage_fit_atf.sh
+++ b/arch/arm/mach-imx/mkimage_fit_atf.sh
@@ -16,7 +16,7 @@ if [ ! -f $BL31 ]; then
 	exit 0
 else
 	echo "$BL31 size: " >&2
-	ls -lct $BL31 | awk '{print $5}' >&2
+	stat -c %s $BL31 >&2
 fi
 
 BL32="tee.bin"
@@ -26,7 +26,7 @@ if [ ! -f $BL32 ]; then
 else
 	echo "Building with TEE support, make sure your $BL31 is compiled with spd. If you do not want tee, please delete $BL31" >&2
 	echo "$BL32 size: " >&2
-	ls -lct $BL32 | awk '{print $5}' >&2
+	stat -c %s $BL32 >&2
 fi
 
 BL33="u-boot-nodtb.bin"
@@ -36,13 +36,13 @@ if [ ! -f $BL33 ]; then
 	exit 0
 else
 	echo "u-boot-nodtb.bin size: " >&2
-	ls -lct u-boot-nodtb.bin | awk '{print $5}' >&2
+	stat -c %s u-boot-nodtb.bin >&2
 fi
 
 for dtname in $*
 do
 	echo "$dtname size: " >&2
-	ls -lct $dtname | awk '{print $5}' >&2
+	stat -c %s $dtname >&2
 done
 
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] imx: mkimage_fit_atf: fix file size reporting
  2021-04-07  4:04 [PATCH] imx: mkimage_fit_atf: fix file size reporting Tim Harvey
@ 2021-05-02 11:42 ` stefano.babic at babic.homelinux.org
  0 siblings, 0 replies; 2+ messages in thread
From: stefano.babic at babic.homelinux.org @ 2021-05-02 11:42 UTC (permalink / raw)
  To: u-boot

> instead using ls and awk to determine file size use stat instead.
> This fixes an invalid size reporting for user or group names that have
> spaces in them.
> This adds a dependency on the stat application which is part of
> the coreutils package which also includes ls.
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-02 11:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-07  4:04 [PATCH] imx: mkimage_fit_atf: fix file size reporting Tim Harvey
2021-05-02 11:42 ` stefano.babic at babic.homelinux.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox