From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [RFC 2/7] freescale: Drop unnecessary cpld_data_t non-typedef
Date: Mon, 3 May 2021 16:48:54 -0400 [thread overview]
Message-ID: <20210503204859.18756-3-trini@konsulko.com> (raw)
In-Reply-To: <20210503204859.18756-1-trini@konsulko.com>
In some board cpld.h files the definition of the cpld_data struct
not-quite makes a typedef for cpld_data_t. This problem is caught with
gcc-11 as a multiple definition error. As there are no users of this
non-typedef, fix this by not declaring it one to begin with.
Cc: Priyanka Jain <priyanka.jain@nxp.com>
Cc: Shengzhou Liu <Shengzhou.Liu@nxp.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
board/freescale/t102xrdb/cpld.h | 2 +-
board/freescale/t104xrdb/cpld.h | 3 +--
board/freescale/t208xrdb/cpld.h | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/board/freescale/t102xrdb/cpld.h b/board/freescale/t102xrdb/cpld.h
index c05f536806fb..bd40cc319a89 100644
--- a/board/freescale/t102xrdb/cpld.h
+++ b/board/freescale/t102xrdb/cpld.h
@@ -21,7 +21,7 @@ struct cpld_data {
u8 boot_override; /* 0x18 - Boot override register */
u8 boot_config1; /* 0x19 - Boot config override register*/
u8 boot_config2; /* 0x1A - Boot config override register*/
-} cpld_data_t;
+};
/* Pointer to the CPLD register set */
diff --git a/board/freescale/t104xrdb/cpld.h b/board/freescale/t104xrdb/cpld.h
index a816aef10a42..769883f9461f 100644
--- a/board/freescale/t104xrdb/cpld.h
+++ b/board/freescale/t104xrdb/cpld.h
@@ -30,8 +30,7 @@ struct cpld_data {
u8 boot_override; /* 0x18 - Boot override register */
u8 boot_config1; /* 0x19 - Boot config override register*/
u8 boot_config2; /* 0x1A - Boot config override register*/
-} cpld_data_t;
-
+};
/* Pointer to the CPLD register set */
diff --git a/board/freescale/t208xrdb/cpld.h b/board/freescale/t208xrdb/cpld.h
index bd6c203742e3..a623b1811faf 100644
--- a/board/freescale/t208xrdb/cpld.h
+++ b/board/freescale/t208xrdb/cpld.h
@@ -21,7 +21,7 @@ struct cpld_data {
u8 boot_or; /* 0x16 - Boot config override register */
u8 boot_cfg1; /* 0x17 - Boot configuration register 1 */
u8 boot_cfg2; /* 0x18 - Boot configuration register 2 */
-} cpld_data_t;
+};
u8 cpld_read(unsigned int reg);
void cpld_write(unsigned int reg, u8 value);
--
2.17.1
next prev parent reply other threads:[~2021-05-03 20:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 20:48 [RFC 0/7] Update CI to using GCC 11.0 / LLVM-11 Tom Rini
2021-05-03 20:48 ` [RFC 1/7] ARM: mvebu: a38x: Correct mismatched bound warnings Tom Rini
2021-07-07 17:33 ` Tom Rini
2021-07-14 20:52 ` Pali Rohár
2021-07-15 7:59 ` Stefan Roese
2021-07-15 13:07 ` [EXT] " Kostya Porotchkin
2021-05-03 20:48 ` Tom Rini [this message]
2021-07-07 17:34 ` [RFC 2/7] freescale: Drop unnecessary cpld_data_t non-typedef Tom Rini
2021-05-03 20:48 ` [RFC 3/7] eb_cpu5282: Declare diplay_width / display_height as externs Tom Rini
2021-07-07 17:34 ` Tom Rini
2021-05-03 20:48 ` [RFC 4/7] pinctrl: mscc: Fix multiple definition error Tom Rini
2021-05-04 7:51 ` Horatiu Vultur
2021-05-04 18:57 ` Daniel Schwierzeck
2021-07-07 17:34 ` Tom Rini
2021-05-03 20:48 ` [RFC 5/7] Makefile: Disable gcc-10.0 warnings Tom Rini
2021-07-07 17:34 ` Tom Rini
2021-05-03 20:48 ` [RFC 6/7] bootstage: Eliminate when not enabled Tom Rini
2021-07-07 17:34 ` Tom Rini
2021-05-03 20:48 ` [RFC 7/7] TEST: Move to gcc-11.0 prerelease and LLVM-11 Tom Rini
2021-06-16 19:58 ` [RFCv2] " Tom Rini
2021-06-16 20:00 ` [RFCv3] Azure/GitLab: Move to gcc-11.1.0 " Tom Rini
2021-06-17 8:27 ` Bin Meng
2021-06-17 12:31 ` Tom Rini
2021-06-17 14:09 ` Bin Meng
2021-06-17 14:14 ` Tom Rini
2021-06-17 14:24 ` Bin Meng
2021-06-17 14:45 ` Tom Rini
2021-06-17 14:51 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503204859.18756-3-trini@konsulko.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox