From: Kishon Vijay Abraham I <kishon@ti.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 03/20] drivers: reset: Handle gracefully NULL pointers
Date: Tue, 4 May 2021 16:11:38 +0530 [thread overview]
Message-ID: <20210504104155.19222-4-kishon@ti.com> (raw)
In-Reply-To: <20210504104155.19222-1-kishon@ti.com>
The reset framework provides devm_reset_control_get_optional()
which can return NULL (not an error case). So all the other reset_ops
should handle NULL gracefully. Prepare the way for a managed reset
API by handling NULL pointers without crashing nor failing.
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/reset/reset-uclass.c | 35 ++++++++++++++++++++++++++++++-----
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c
index ac89eaf098..18dfe06d1c 100644
--- a/drivers/reset/reset-uclass.c
+++ b/drivers/reset/reset-uclass.c
@@ -162,7 +162,12 @@ int reset_get_by_name(struct udevice *dev, const char *name,
int reset_request(struct reset_ctl *reset_ctl)
{
- struct reset_ops *ops = reset_dev_ops(reset_ctl->dev);
+ struct reset_ops *ops;
+
+ if (!reset_ctl)
+ return 0;
+
+ ops = reset_dev_ops(reset_ctl->dev);
debug("%s(reset_ctl=%p)\n", __func__, reset_ctl);
@@ -171,7 +176,12 @@ int reset_request(struct reset_ctl *reset_ctl)
int reset_free(struct reset_ctl *reset_ctl)
{
- struct reset_ops *ops = reset_dev_ops(reset_ctl->dev);
+ struct reset_ops *ops;
+
+ if (!reset_ctl)
+ return 0;
+
+ ops = reset_dev_ops(reset_ctl->dev);
debug("%s(reset_ctl=%p)\n", __func__, reset_ctl);
@@ -180,7 +190,12 @@ int reset_free(struct reset_ctl *reset_ctl)
int reset_assert(struct reset_ctl *reset_ctl)
{
- struct reset_ops *ops = reset_dev_ops(reset_ctl->dev);
+ struct reset_ops *ops;
+
+ if (!reset_ctl)
+ return 0;
+
+ ops = reset_dev_ops(reset_ctl->dev);
debug("%s(reset_ctl=%p)\n", __func__, reset_ctl);
@@ -202,7 +217,12 @@ int reset_assert_bulk(struct reset_ctl_bulk *bulk)
int reset_deassert(struct reset_ctl *reset_ctl)
{
- struct reset_ops *ops = reset_dev_ops(reset_ctl->dev);
+ struct reset_ops *ops;
+
+ if (!reset_ctl)
+ return 0;
+
+ ops = reset_dev_ops(reset_ctl->dev);
debug("%s(reset_ctl=%p)\n", __func__, reset_ctl);
@@ -224,7 +244,12 @@ int reset_deassert_bulk(struct reset_ctl_bulk *bulk)
int reset_status(struct reset_ctl *reset_ctl)
{
- struct reset_ops *ops = reset_dev_ops(reset_ctl->dev);
+ struct reset_ops *ops;
+
+ if (!reset_ctl)
+ return 0;
+
+ ops = reset_dev_ops(reset_ctl->dev);
debug("%s(reset_ctl=%p)\n", __func__, reset_ctl);
--
2.17.1
next prev parent reply other threads:[~2021-05-04 10:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 10:41 [PATCH v3 00/20] TI/Cadence: Add Sierra/Torrent SERDES driver Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 01/20] dm: core: Add helper to compare node names Kishon Vijay Abraham I
2021-05-04 16:58 ` Simon Glass
2021-05-04 10:41 ` [PATCH v3 02/20] dm: test: Add test case to check node name ignoring unit address Kishon Vijay Abraham I
2021-05-04 10:41 ` Kishon Vijay Abraham I [this message]
2021-05-04 16:58 ` [PATCH v3 03/20] drivers: reset: Handle gracefully NULL pointers Simon Glass
2021-05-05 4:25 ` Kishon Vijay Abraham I
2021-05-05 23:37 ` Simon Glass
2021-05-06 13:09 ` Kishon Vijay Abraham I
2021-05-06 15:06 ` Simon Glass
2021-05-04 10:41 ` [PATCH v3 04/20] dt-bindings: phy: Add definitions for additional phy types Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 05/20] dt-bindings: phy: Add defines for AM64 SERDES Wrapper Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 06/20] dt-bindings: phy: cadence-torrent: Add defines for refclk driver Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 07/20] dt-bindings: ti-serdes-mux: Add defines for AM64 SoC Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 08/20] phy: cadence: Add driver for Sierra PHY Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 09/20] phy: cadence: Add driver for Torrent SERDES Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 10/20] phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 11/20] usb: cdns3: cdns3-ti: Fix clk_get_by_name() to get the correct name Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 12/20] board: ti: j721e: Add support for probing and configuring Torrent serdes on J7200 Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 13/20] ARM: dts: k3-j721e: Add the entries required for USB3 support on USB0 Kishon Vijay Abraham I
2021-05-07 17:14 ` Tom Rini
2021-07-09 14:06 ` Kishon Vijay Abraham I
2021-07-09 14:16 ` Tom Rini
2021-05-04 10:41 ` [PATCH v3 14/20] arm: dts: k3-j7200-main: Add DT node for torrent serdes Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 15/20] arm: dts: k3-j7200-common-proc-board: Enable SERDES DT Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 16/20] arm: dts: k3-j7200-common-proc-board-u-boot: Add u-boot tags for torrent serdes Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 17/20] configs: j721e_evm_a72: Enable the drivers required for the USB3 support Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 18/20] configs: j7200_evm_a72_defconfig: Add config for torrent serdes and common clock framework Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 19/20] env: ti: j721e-evm: Add env variable to power on & reset QSGMII PHY in J7200 EVM Kishon Vijay Abraham I
2021-05-07 17:14 ` Tom Rini
2021-05-11 13:58 ` Kishon Vijay Abraham I
2021-05-11 14:33 ` Tom Rini
2021-07-09 14:32 ` Kishon Vijay Abraham I
2021-07-09 14:36 ` Tom Rini
2021-05-04 10:41 ` [PATCH v3 20/20] configs: j7200_evm_a72: Enhance bootcmd to configure ethernet PHY Kishon Vijay Abraham I
2021-05-07 17:16 ` [PATCH v3 00/20] TI/Cadence: Add Sierra/Torrent SERDES driver Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504104155.19222-4-kishon@ti.com \
--to=kishon@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox