Re: [PATCH 25/27] ppc: Remove T4160RDB board

Tom Rini
2021-06-08T12:06:51Z

[-- Attachment #1: Type: text/plain, Size: 4878 bytes --]

On Tue, Jun 08, 2021 at 07:36:31AM +0000, Priyanka Jain wrote:
>
>
> >-----Original Message-----
> >From: Tom Rini <trini@konsulko.com>
> >Sent: Friday, May 21, 2021 11:09 PM
> >To: Camelia Alexandra Groza (OSS) <camelia.groza@oss.nxp.com>
> >Cc: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com>
> >Subject: Re: [PATCH 25/27] ppc: Remove T4160RDB board
> >
> >On Fri, May 21, 2021 at 04:10:12PM +0000, Camelia Alexandra Groza (OSS) wrote:
> >> > -----Original Message-----
> >> > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Tom Rini
> >> > Sent: Saturday, May 15, 2021 4:35
> >> > To: u-boot@lists.denx.de
> >> > Subject: [PATCH 25/27] ppc: Remove T4160RDB board
> >> >
> >> > This board has not been converted to CONFIG_DM_PCI by the deadline
> >> > and is also missing conversion to CONFIG_DM. Remove it. As this is
> >> > the last
> >> > ARCH_T4160 platform, remove that support as well.
> >> >
> >> > Signed-off-by: Tom Rini <trini@konsulko.com>
> >> > ---
> >> > arch/powerpc/cpu/mpc85xx/Kconfig | 37 +-
> >> > arch/powerpc/cpu/mpc85xx/Makefile | 2 -
> >> > arch/powerpc/cpu/mpc85xx/fdt.c | 5 +-
> >> > arch/powerpc/cpu/mpc85xx/speed.c | 3 +-
> >> > arch/powerpc/cpu/mpc85xx/t4240_serdes.c | 202 -------
> >> > arch/powerpc/include/asm/config_mpc85xx.h | 5 +-
> >> > arch/powerpc/include/asm/immap_85xx.h | 4 +-
> >> > board/freescale/t4rdb/Kconfig | 14 -
> >> > board/freescale/t4rdb/MAINTAINERS | 8 -
> >> > board/freescale/t4rdb/Makefile | 19 -
> >> > board/freescale/t4rdb/cpld.c | 129 -----
> >> > board/freescale/t4rdb/cpld.h | 48 --
> >> > board/freescale/t4rdb/ddr.c | 128 -----
> >> > board/freescale/t4rdb/ddr.h | 77 ---
> >> > board/freescale/t4rdb/eth.c | 152 -----
> >> > board/freescale/t4rdb/law.c | 30 -
> >> > board/freescale/t4rdb/pci.c | 25 -
> >> > board/freescale/t4rdb/spl.c | 98 ----
> >> > board/freescale/t4rdb/t4240rdb.c | 153 -----
> >> > board/freescale/t4rdb/t4_pbi.cfg | 27 -
> >> > board/freescale/t4rdb/t4_sd_rcw.cfg | 7 -
> >> > board/freescale/t4rdb/t4rdb.h | 17 -
> >> > board/freescale/t4rdb/tlb.c | 123 ----
> >> > configs/T4160RDB_defconfig | 57 --
> >> > configs/T4240RDB_SDCARD_defconfig | 80 ---
> >> > configs/T4240RDB_defconfig | 68 ---
> >> > drivers/ddr/fsl/Kconfig | 3 +-
> >> > drivers/net/Kconfig | 1 -
> >> > drivers/net/fm/Makefile | 1 -
> >> > include/configs/T4240RDB.h | 667 ----------------------
> >> > 30 files changed, 8 insertions(+), 2182 deletions(-) delete mode
> >> > 100644 board/freescale/t4rdb/Kconfig delete mode 100644
> >> > board/freescale/t4rdb/MAINTAINERS delete mode 100644
> >> > board/freescale/t4rdb/Makefile delete mode 100644
> >> > board/freescale/t4rdb/cpld.c delete mode 100644
> >> > board/freescale/t4rdb/cpld.h delete mode 100644
> >> > board/freescale/t4rdb/ddr.c delete mode 100644
> >> > board/freescale/t4rdb/ddr.h delete mode 100644
> >> > board/freescale/t4rdb/eth.c delete mode 100644
> >> > board/freescale/t4rdb/law.c delete mode 100644
> >> > board/freescale/t4rdb/pci.c delete mode 100644
> >> > board/freescale/t4rdb/spl.c delete mode 100644
> >> > board/freescale/t4rdb/t4240rdb.c delete mode 100644
> >> > board/freescale/t4rdb/t4_pbi.cfg delete mode 100644
> >> > board/freescale/t4rdb/t4_sd_rcw.cfg
> >> > delete mode 100644 board/freescale/t4rdb/t4rdb.h delete mode
> >> > 100644 board/freescale/t4rdb/tlb.c delete mode 100644
> >> > configs/T4160RDB_defconfig delete mode 100644
> >> > configs/T4240RDB_SDCARD_defconfig delete mode 100644
> >> > configs/T4240RDB_defconfig delete mode 100644
> >> > include/configs/T4240RDB.h
> >>
> >> Hi Tom
> >>
> >> The T4240RDB has DM_PCI enabled. Why is it also getting removed?
> >> Am I missing something?
> >
> >Please note that board/freescale/t4rdb/MAINTAINERS needs to be updated with
> >a responsible maintainer, thanks.
>
> Hello Tom,
>
> I will submit patch to add myself as MAINTAINER in board/freescale/t4rdb/MAINTAINERS.
> Kindly don't remove the board support.

OK, but note that there's two things going on here. There's (1) the
boards with an orphaned maintainer setting and (2) boards without DM_PCI
migration. I'm not (intentionally) removing boards that hit problem #1
but I am removing boards that hit problem #2. Since you posted a series
to update MAINTAINERS only, I assume that nothing in that second
category is something you want to keep.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]