From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Mon, 17 May 2021 09:10:36 +0200 Subject: [PATCH 1/1] fs/squashfs: zero out unused fields in fs_dirent In-Reply-To: <20210517062139.101617-1-xypron.glpk@gmx.de> References: <20210517062139.101617-1-xypron.glpk@gmx.de> Message-ID: <20210517091036.25768ba8@xps13> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heinrich, Heinrich Schuchardt wrote on Mon, 17 May 2021 08:21:39 +0200: > When reading directories the UEFI sub-system must supply file attributes > and timestamps. These fields will have to be added to struct fs_dirent. > SquashFS should not fill these fields with random data. Ensure that they > are zeroed out. > > Signed-off-by: Heinrich Schuchardt > --- > fs/squashfs/sqfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c > index 29805c3c6f..997be2dcf4 100644 > --- a/fs/squashfs/sqfs.c > +++ b/fs/squashfs/sqfs.c > @@ -876,7 +876,7 @@ int sqfs_opendir(const char *filename, struct fs_dir_stream **dirsp) > char **token_list = NULL, *path = NULL; > u32 *pos_list = NULL; > > - dirs = malloc(sizeof(*dirs)); > + dirs = calloc(1, sizeof(*dirs)); > if (!dirs) > return -EINVAL; > > -- > 2.30.2 > Reviewed-by: Miquel Raynal Thanks, Miqu?l