From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 27/28] fs/squashfs: sqfs_read: fragmented files are not supported
Date: Mon, 17 May 2021 09:47:41 -0400 [thread overview]
Message-ID: <20210517134741.GX17669@bill-the-cat> (raw)
In-Reply-To: <CABfBAmBqgdPC0aXD2y_sGzd=FkY4K-+wpyfDdkWFJgdUX7ep0w@mail.gmail.com>
On Sun, May 16, 2021 at 09:44:53PM -0300, Jo?o Marcos Costa wrote:
> Hello,
>
> Em ter., 11 de mai. de 2021 ?s 10:04, Richard Genoud <
> richard.genoud at posteo.net> escreveu:
>
> > Hi all,
> >
> > Le 08/05/2021 ? 23:51, Simon Glass a ?crit :
> > > Hi,
> > >
> > > On Thu, 4 Feb 2021 at 15:32, Jo?o Marcos Costa <jmcosta944@gmail.com>
> > wrote:
> > >>
> > >> Em qua., 27 de jan. de 2021 ?s 12:15, Simon Glass <sjg@chromium.org>
> > escreveu:
> > >>>
> > >>> Hi Joao,
> > >>
> > >> Hello!
> > >>>
> > >>> This test works the first time I run it but fails the second time,
> > >>> since the directory already exists. This makes it necessary to disable
> > >>> the test for development.
> > >>>
> > >>> It also uses the wrong quoting style - we have settled on a single
> > >>> quote by default in U-Boot.
> > >>>
> > >>> Finally, the tests and some functions need comments about what they do
> > >>> and what the arguments are.
> > >>>
> > >>> Please can you take a look?
> > >>
> > >> Absolutely. Excuse me for such a late reply.
> > >
> > > Any word on this please? Have you been able to repeat this?
> > Yes, for me, reading fragmented files doesn't work.
> > The test "test_sqfs_load" is OK because it only tests the file length not
> > its content.
> >
> > I've written a patch to check if the file is corrupted or not, and it
> > fails :
> > ./test/py/test.py --bd sandbox --build -k test_sqfs_load -v
> > [...]
> >
>
> I finally could get back to SquashFS support today, and I fixed a few bugs
> concerning the fragmented files. However, I still need to run a few more
> tests before submitting the patches.
Please make sure the problem with repeatedly running the tests is fixed
as well, that's what's blocking using the public gitlab CI runners,
thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210517/51061c43/attachment.sig>
next prev parent reply other threads:[~2021-05-17 13:47 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:10 [PATCH v2 00/28] fs/squashfs: fix memory leaks and introduce exists() function Richard Genoud
2020-11-03 11:10 ` [PATCH v2 01/28] fs/squashfs: fix board hang-up when calling .exists() Richard Genoud
2020-11-03 12:31 ` João Marcos Costa
2020-11-20 1:36 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 02/28] fs/squashfs: sqfs_opendir: fix some memory leaks and dangling pointers Richard Genoud
2020-11-20 1:36 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 03/28] fs/squashfs: sqfs_opendir: simplify error handling Richard Genoud
2020-11-03 12:33 ` João Marcos Costa
2020-11-20 1:36 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 04/28] fs/squashfs: sqfs_closedir: fix memory leak Richard Genoud
2020-11-03 12:35 ` João Marcos Costa
2020-11-20 1:36 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 05/28] fs/squashfs: sqfs_split_path: fix memory leak and dangling pointers Richard Genoud
2020-11-03 12:37 ` João Marcos Costa
2020-11-20 1:36 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 06/28] fs/squashfs: sqfs_read_directory_table: fix memory leak Richard Genoud
2020-11-03 12:38 ` João Marcos Costa
2020-11-20 1:36 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 07/28] fs/squashfs: sqfs_search_dir: fix dangling pointer Richard Genoud
2020-11-20 1:36 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 08/28] fs/squashfs: sqfs_search_dir: fix memory leaks Richard Genoud
2020-11-03 12:39 ` João Marcos Costa
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 09/28] fs/squashfs: sqfs_read_inode_table: fix dangling pointer Richard Genoud
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 10/28] fs/squashfs: sqfs_concat_tokens: check if malloc succeeds Richard Genoud
2020-11-03 12:40 ` João Marcos Costa
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 11/28] fs/squashfs: sqfs_size: fix dangling pointer dirs->entry Richard Genoud
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 12/28] fs/squashfs: sqfs_size: remove useless sqfs_closedir() Richard Genoud
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 13/28] fs/squashfs: sqfs_read: fix dangling pointer dirs->entry Richard Genoud
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 14/28] fs/squashfs: sqfs_read: remove useless sqfs_closedir() Richard Genoud
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 15/28] fs/squashfs: sqfs_read: fix memory leak Richard Genoud
2020-11-03 12:41 ` João Marcos Costa
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 16/28] fs/squashfs: sqfs_read: fix another " Richard Genoud
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 17/28] fs/squashfs: sqfs_frag_lookup: simplify error handling Richard Genoud
2020-11-03 12:44 ` João Marcos Costa
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 18/28] fs/squashfs: sqfs_get_abs_path: fix error check Richard Genoud
2020-11-03 12:44 ` João Marcos Costa
2020-11-20 1:37 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 19/28] fs/squashfs: sqfs_get_abs_path: fix possible memory leak on error Richard Genoud
2020-11-03 12:44 ` João Marcos Costa
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 20/28] fs/squashfs: sqfs_read: fix memory leak on finfo.blk_sizes Richard Genoud
2020-11-03 12:45 ` João Marcos Costa
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 21/28] fs/squashfs: sqfs_probe: fix possible memory leak on error Richard Genoud
2020-11-03 12:46 ` João Marcos Costa
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 22/28] fs/squashfs: sqfs_close/sqfs_read_sblk: set ctxt.sblk to NULL after free Richard Genoud
2020-11-20 1:35 ` Tom Rini
2020-11-20 14:39 ` Richard Genoud
2020-11-03 11:11 ` [PATCH v2 23/28] fs/squashfs: sqfs_probe: reset cur_dev/cur_part_info to NULL on error Richard Genoud
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 24/28] fs/squashfs: sqfs_probe: use sqfs_decompressor_init() return value Richard Genoud
2020-11-03 12:46 ` João Marcos Costa
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 25/28] fs/squashfs: sqfs_read: don't write beyond buffer size Richard Genoud
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 26/28] fs/squashfs: sqfs_read: remove buggy offset functionality Richard Genoud
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:11 ` [PATCH v2 27/28] fs/squashfs: sqfs_read: fragmented files are not supported Richard Genoud
2020-11-20 1:35 ` Tom Rini
2020-11-25 8:58 ` Richard Genoud
2021-01-27 15:15 ` Simon Glass
2021-02-04 23:31 ` João Marcos Costa
2021-05-08 21:51 ` Simon Glass
2021-05-11 13:04 ` Richard Genoud
2021-05-17 0:44 ` João Marcos Costa
2021-05-17 13:47 ` Tom Rini [this message]
2020-11-03 11:11 ` [PATCH v2 28/28] fs/squashfs: implement exists() function Richard Genoud
2020-11-03 12:48 ` João Marcos Costa
2020-11-20 1:38 ` Tom Rini
2020-11-03 11:18 ` [PATCH v2 00/28] fs/squashfs: fix memory leaks and introduce " Richard Genoud
2020-11-03 13:08 ` João Marcos Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517134741.GX17669@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox