[PATCH 00/18] image: Reduce #ifdef abuse in image code

Alexandru Gagniuc
2021-05-17T16:38:22Z

This is a combination of select patches from Simon's series:
"image: Reduce #ifdefs and ad-hoc defines in image code"
and alternative solutions I proposed in:
"image: Reduce the abuse of #ifdefs in image-sig.c"

After syncing with Simon, we agree that this is a reasonable base for
further work in #ifdef reduction. Rather than describing changes from
Simon's series or mine, we present this series de novo.
Most patches are already peer-reviewed.

The latest patch in this series is optional:
'image: Add support for relocating crypto_algos in linker lists"
I don't have a way to test it, and I don't know if it's still needed.
I have included it for completeness.

Alexandru Gagniuc (10):
common: Move host-only logic in image-sig.c to separate file
common: image-sig.c: Remove host-specific logic and #ifdefs
image: Add support for placing crypto_algo in linker lists
image: rsa: Move verification algorithm to a linker list
image: image-sig.c: Remove crypto_algos array
lib: ecdsa: Remove #ifdefs from ecdsa.h
lib: rsa: Remove #ifdefs from rsa.h
image: Eliminate IMAGE_ENABLE_VERIFY macro
image: Eliminate IMAGE_ENABLE_VERIFY_ECDSA macro
[UNTESTED] image: Add support for relocating crypto_algos in linker
lists

Simon Glass (8):
image: Shorten FIT_ENABLE_SHAxxx_SUPPORT
image: Rename SPL_SHAxxx_SUPPORT to SPL_FIT_SHAxxx
image: Rename CONFIG_FIT_ENABLE_RSASSA_PSS_SUPPORT
Kconfig: Rename SPL_CRC32_SUPPORT to SPL_CRC32
Kconfig: Rename SPL_MD5_SUPPORT to SPL_MD5
image: Drop IMAGE_ENABLE_SHA1
image: Drop IMAGE_ENABLE_SHAxxx
image: Drop IMAGE_ENABLE_BEST_MATCH

common/Kconfig.boot | 8 +-
common/image-fit.c | 10 +-
common/image-sig.c | 75 +++---------
common/spl/Kconfig | 14 +--
configs/axm_defconfig | 2 +-
configs/bcm963158_ram_defconfig | 2 +-
configs/chromebit_mickey_defconfig | 2 +-
configs/chromebook_jerry_defconfig | 2 +-
configs/chromebook_minnie_defconfig | 2 +-
configs/chromebook_speedy_defconfig | 2 +-
configs/evb-px30_defconfig | 2 +-
configs/firefly-px30_defconfig | 2 +-
configs/imxrt1020-evk_defconfig | 2 +-
configs/imxrt1050-evk_defconfig | 2 +-
configs/mt8516_pumpkin_defconfig | 2 +-
configs/odroid-go2_defconfig | 2 +-
configs/px30-core-ctouch2-px30_defconfig | 2 +-
configs/px30-core-edimm2.2-px30_defconfig | 2 +-
configs/sandbox_defconfig | 2 +-
configs/socfpga_agilex_atf_defconfig | 2 +-
configs/socfpga_agilex_vab_defconfig | 2 +-
configs/socfpga_stratix10_atf_defconfig | 2 +-
configs/taurus_defconfig | 2 +-
include/image.h | 59 ++--------
include/u-boot/ecdsa.h | 25 ----
include/u-boot/rsa.h | 51 +--------
lib/rsa/rsa-sign.c | 4 +-
lib/rsa/rsa-verify.c | 18 ++-
tools/Makefile | 5 +-
tools/image-sig-host.c | 133 ++++++++++++++++++++++
30 files changed, 220 insertions(+), 220 deletions(-)
create mode 100644 tools/image-sig-host.c

--
2.31.1