From: Anand Moon <linux.amoon@gmail.com>
To: u-boot@lists.denx.de
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Kever Yang <kever.yang@rock-chips.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Patrick Wildt <patrick@blueri.se>,
Anand Moon <linux.amoon@gmail.com>
Subject: [PATCHv2 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error
Date: Fri, 21 May 2021 16:59:47 +0000 [thread overview]
Message-ID: <20210521165949.15909-1-linux.amoon@gmail.com> (raw)
Use the generic error number instead of specific error number.
Changes fix the below error.
drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_read':
drivers/pci/pcie_dw_rockchip.c:70:10: error: 'PCIBIOS_UNSUPPORTED'
undeclared (first use in this function)
70 | return PCIBIOS_UNSUPPORTED;
| ^~~~~~~~~~~~~~~~~~~
drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_write':
drivers/pci/pcie_dw_rockchip.c:90:10: error: 'PCIBIOS_UNSUPPORTED'
undeclared (first use in this function)
90 | return PCIBIOS_UNSUPPORTED;
| ^~~~~~~~~~~~~~~~~~~
Cc: Patrick Wildt <patrick@blueri.se>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kever Yang <kever.yang@rock-chips.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v1: Drop the PCI ERROR MACRO,
---
drivers/pci/pcie_dw_rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
index bc22af4230..3ac2434b69 100644
--- a/drivers/pci/pcie_dw_rockchip.c
+++ b/drivers/pci/pcie_dw_rockchip.c
@@ -67,7 +67,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
{
if ((uintptr_t)addr & (size - 1)) {
*val = 0;
- return PCIBIOS_UNSUPPORTED;
+ return -EOPNOTSUPP;
}
if (size == 4) {
@@ -87,7 +87,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
static int rk_pcie_write(void __iomem *addr, int size, u32 val)
{
if ((uintptr_t)addr & (size - 1))
- return PCIBIOS_UNSUPPORTED;
+ return -EOPNOTSUPP;
if (size == 4)
writel(val, addr);
--
2.31.1
next reply other threads:[~2021-05-21 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 16:59 Anand Moon [this message]
2021-05-21 16:59 ` [PATCHv2 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning Anand Moon
2021-05-31 8:42 ` Neil Armstrong
2021-05-21 16:59 ` [PATCHv2 3/3] pci: pcie_dw_rockchip: Use mleep macro to fix below error Anand Moon
2021-05-31 8:44 ` Neil Armstrong
2021-05-31 8:42 ` [PATCHv2 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521165949.15909-1-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=narmstrong@baylibre.com \
--cc=patrick@blueri.se \
--cc=shawn.lin@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox