Re: [PATCHv2 3/3] pci: pcie_dw_rockchip: Use mleep macro to fix below error

Neil Armstrong
2021-05-31T08:44:32Z

> Define msleep macro to fix below error.
>
> drivers/pci/pcie_dw_rockchip.c:254:3: warning: implicit
> declaration of function 'msleep' [-Wimplicit-function-declaration]
>
> Cc: Patrick Wildt <patrick@blueri.se>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v1: drop the udelay changes.
> ---
> drivers/pci/pcie_dw_rockchip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> index 4e448c0a3d..bdc4d51007 100644
> --- a/drivers/pci/pcie_dw_rockchip.c
> +++ b/drivers/pci/pcie_dw_rockchip.c
> @@ -60,6 +60,7 @@ struct rk_pcie {
> #define PCIE_CLIENT_DBG_TRANSITION_DATA 0xffff0000
> #define PCIE_CLIENT_DBF_EN 0xffff0003
>
> +#define msleep(a) udelay((a) * 1000)
> /* Parameters for the waiting for #perst signal */
> #define PERST_WAIT_MS 1000
>
>

Please replace msleep occurences by udelay with either:
- udelay(MACRO_MS * 1000)
- udelay(MACRO_US) and replace MACRO_MS with MACRO_US with values *1000

Neil