From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 315AEC04FF3 for ; Mon, 24 May 2021 19:54:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6000A61400 for ; Mon, 24 May 2021 19:54:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6000A61400 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C243782EA2; Mon, 24 May 2021 21:54:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Q1+Uh3G5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4FD2A82EA2; Mon, 24 May 2021 21:54:32 +0200 (CEST) Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B3FC382EBA for ; Mon, 24 May 2021 21:54:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf29.google.com with SMTP id e8so11554412qvp.7 for ; Mon, 24 May 2021 12:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GTjQx/1NH5pvOIVuXu9mk3Y1ZKzpGzv8lc2RZ5k4dXc=; b=Q1+Uh3G5sTcElKBHYgqLvMqravhQM/uoz4VxW4CfTDiw/d1vU9Ht6UbXU2I3t0T1jR PsdlxxX1nlC7sH95Ub24YCycTgX/Z9WLzjLRvOtuvGytXLzn0BnaFMq3cC8saxpesdeD ipYBMnSeOvsoSeVBbGWai0cf75hP41q8CSiio= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GTjQx/1NH5pvOIVuXu9mk3Y1ZKzpGzv8lc2RZ5k4dXc=; b=bBqlB0RPnu7bjBPh6GyrheCZaJ7ZpHPbz9Uuxh/qB7jeTJHC8bAM3mKBKJVwkqbVM7 H19LI2xCEnsCKIrVi+x1fl1Jx0115xOfsn/9l7RXLNENo1r+a/09ph/rU0tv8wX94Znw 7zZh34CwJDWSDbLg9fWSKR1MioHln/KlOtXPyCrah7kQWN2vlZbx+j6D1X07CDNn2k/Z IpfWgNdxD7J4chlbQ04IkN0CdR5mgCXSx33h/oU8DLImboLiFL0H0Txw3wfPYzrtIhBB nBgbiuEHj6nlRPiRmqDLQ1bMJUyGVybN41o31SvJRWLt3QhRGCJK7gf9KXxQKgd55SOq hnaQ== X-Gm-Message-State: AOAM532WUlKqi8jSyduV4QF50OoEkMSEIkLtFngpW7C6EnvveSdo+M0+ Qu65MzlVEe0MG5vLSTIaHVOqdg== X-Google-Smtp-Source: ABdhPJy/Pd18iu1XZZeiZ+uEFhjOplzYBngk/dQHYVdL1AtIqrcrMCyONlnIwHeX3bnq2kMr7BxWQQ== X-Received: by 2002:a0c:9a4e:: with SMTP id q14mr32028052qvd.15.1621886064589; Mon, 24 May 2021 12:54:24 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5ce8-9acb-4a3a-47a0.res6.spectrum.com. [2603:6081:7b01:cbda:5ce8:9acb:4a3a:47a0]) by smtp.gmail.com with ESMTPSA id j15sm9420752qtv.11.2021.05.24.12.54.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 May 2021 12:54:23 -0700 (PDT) Date: Mon, 24 May 2021 15:54:21 -0400 From: Tom Rini To: Marek Behun Cc: Adam Ford , U-Boot Mailing List , Simon Glass , Heiko Schocher , Patrick Delaunay , Patrice CHOTARD , Miquel Raynal , Pali =?iso-8859-1?Q?Roh=E1r?= , Stefan Roese , Heinrich Schuchardt , Alexander Graf , Marek Vasut , Neil Armstrong , Ryder Lee , Bin Meng , Harald Seiler , Tim Harvey Subject: Re: [PATCH u-boot v4 36/36] ARM: enable LTO for some boards Message-ID: <20210524195421.GE17669@bill-the-cat> References: <20210520112425.25166-1-marek.behun@nic.cz> <20210520112425.25166-37-marek.behun@nic.cz> <20210521141147.GG17669@bill-the-cat> <20210521180031.08b842e0@dellmb> <20210521165641.GK17669@bill-the-cat> <20210524154053.GA17669@bill-the-cat> <20210524175855.2090a751@thinkpad> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hFciDCnh/uIldpri" Content-Disposition: inline In-Reply-To: <20210524175855.2090a751@thinkpad> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --hFciDCnh/uIldpri Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 24, 2021 at 05:58:55PM +0200, Marek Behun wrote: > On Mon, 24 May 2021 11:40:53 -0400 > Tom Rini wrote: >=20 > > On Fri, May 21, 2021 at 12:56:41PM -0400, Tom Rini wrote: > > > On Fri, May 21, 2021 at 06:00:31PM +0200, Marek Beh=FAn wrote: =20 > > > > On Fri, 21 May 2021 10:11:47 -0400 > > > > Tom Rini wrote: > > > > =20 > > > > > On Thu, May 20, 2021 at 01:56:29PM -0500, Adam Ford wrote: =20 > > > > > > On Thu, May 20, 2021 at 6:25 AM Marek Beh=FAn > > > > > > wrote: =20 > > > > > > > > > > > > > > Enable LTO for some boards that were tested by people on U-Bo= ot > > > > > > > Mailing List. > > > > > > > > > > > > > > Signed-off-by: Marek Beh=FAn > > > > > > > Tested-by: Adam Ford > > > > > > > Tested-by: Pali Roh=E1r > > > > > > > Tested-by: Tim Harvey =20 > > > > > >=20 > > > > > > Since the imx8mm beacon boards and the imx8mm venice board both= show > > > > > > promise, does it make sense to 'imply' the LTO for anything ena= bling > > > > > > imx8mm? > > > > > > Same thing for the various omap3 boards, and potentially the re= nesas > > > > > > RZ/G2 boards. I know Tom went through to remove a bunch of boa= rds > > > > > > that were never converted to DM. Most of the boards remaining > > > > > > boards have minimal board files and most of code is common to o= ther > > > > > > boards in the same platforms. > > > > > >=20 > > > > > > I have an l138_lcdk that I can use to test which I expect to be > > > > > > similar to the da850evm. =20 > > > > >=20 > > > > > As much as I am eager to move everything, quickly, over to LTO by > > > > > default, I think the problems that we've seen thus far show it's = best > > > > > to really make it an explicit enable per board at least for the f= irst > > > > > release or two. Once we've hopefully gotten more boards tested a= nd > > > > > enabled we can see what makes sense for defaults, give a release = worth > > > > > of heads up, and then go. =20 > > > >=20 > > > > Tom, are there some other issues aside from the one failing CI scen= ario > > > > (sandbox_clang)? Would you be willing to merge this if I resolved t= hat > > > > one fail by disabling LTO for that scenario (until I resolve it)? It > > > > would help me not having to maintain all 30+ patches... =20 > > >=20 > > > Yeah, CI needs to keep passing, so if we need to disable > > > sandbox+clang+lto for now, OK. =20 > >=20 > > Ah, I see the problem now. I've worked out a fix after looking at the > > Linux kernel a bit and I'll post something for us and upstream dtc as > > well. > >=20 >=20 > What do you mean? The problem is in dtc? I see 2 problems: > - one with DM test So, this looks like another case of the optimizer being so good it causes the test to fail. Happily in this case, a patch Simon made to fix coverity complaining about using srand/rand here: https://patchwork.ozlabs.org/project/uboot/patch/20210514014011.2832707-5-s= jg@chromium.org/ also gets the test passing with LTO. --=20 Tom --hFciDCnh/uIldpri Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmCsBGYACgkQFHw5/5Y0 tyxSxwv7Bsg0NziBCC5+z0OA+r8MpNpA1YVLp9Ldcf4PHZVqss45ip+eidD1kXID 1NTltl7wklblCTHxtmxVAFNHXv6Ziad5kmxlqggTlRn5RSCLyCyjcz8bdOsTCuDE Ad+k1Z+YXP9Yzaon3QywJhvNYiwD89lfS8grhZvqa836mdjFVaDQIqdAiHyiEyor WgnRAutGgSzd11qGVre3lsKZ38822mwM+5MiojNWHfDJyD6LddzJiR6g7l8/7+Wj kqtpVDykNxX6ppWRg70jC6G39YSNOzEs2FZk/nhZKQHGbQyO01JYegxhiFuzJt5p 3S+5IHaNAKigagYK/apsvk4ZhfA4f0xVBELrlhEwQSvjvYy3c5TlewUdvSaowS7K ckdzVKymaXU6Gft9PGPGb3phkD+7T5fxxbdsy2EJ56w9PwSgWV654OZ0UztaRwer jo/JewudW8krErvfzTi93T3olmi+bI2I17odDyoE2mowo1ChnSvdj/eb7Q9McbDK 5ufEB+Xq =ISA6 -----END PGP SIGNATURE----- --hFciDCnh/uIldpri--