[PATCH] pytest:Shutdown power-supply to board after the pytest execution

[PATCH] pytest:Shutdown power-supply to board after the pytest execution

[opensource.kab]

From: Adarsh Babu Kalepalli <opensource.kab@gmail.com>

After executing the test-cases from pytest ,the board
is still powered.Shutting down the board power supply at
this point ,would keep the board safe.

Signed-off-by: Adarsh Babu Kalepalli <opensource.kab@gmail.com>
---

 test/py/conftest.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/test/py/conftest.py b/test/py/conftest.py
index 11a3f307ea..077358a37f 100644
--- a/test/py/conftest.py
+++ b/test/py/conftest.py
@@ -406,6 +406,13 @@ def cleanup():
     """
 
     if console:
+        if ((console.config.board_type != "sandbox") and (console.config.board_type != "sandbox64")):
+            args = [console.config.board_type, console.config.board_identity]
+            console.log.action('Powering Down the board')
+            cmd = ['u-boot-test-power-off'] + args
+            runner = console.log.get_runner(cmd[0], sys.stdout)
+            runner.run(cmd)
+            runner.close()
         console.close()
     if log:
         with log.section('Status Report', 'status_report'):
-- 
2.17.1

Re: [PATCH] pytest:Shutdown power-supply to board after the pytest execution

[Stephen Warren]

On 5/27/21 2:33 AM, opensource.kab@gmail.com wrote:
> From: Adarsh Babu Kalepalli <opensource.kab@gmail.com>
> 
> After executing the test-cases from pytest ,the board
> is still powered.Shutting down the board power supply at
> this point ,would keep the board safe.

FWIW, this violates the original design of the test system. Turning the 
board off at the end of the test is a policy decision that not all 
use-cases will want, and hence not something that the test system should 
mandate. Instead, the intention is for the user to invoke the test 
system using a script that does something like:

1) Power on board.
2) Run test.
3) Power off board.

See ./doc/develop/py_testing.rst in the U-Boot source for more 
background info, or the following URL for an example script:

https://github.com/swarren/u-boot-ci-scripts/blob/master/test.sh

Re: [PATCH] pytest:Shutdown power-supply to board after the pytest execution

[Adarsh Babu Kalepalli]

Hi Stephen,

> FWIW, this violates the original design of the test system. Turning the
> board off at the end of the test is a policy decision that not all
> use-cases will want,

Wasn't aware that powering OFF the board would not be a preferred choice
for certain test cases.
Executing python test cases on sandbox or Beaglebone Black with this
power-off feature, did  not
cause me any issues.So,thought this would be a 'good to use' feature in the
python test framework.Hence,this patch.

As recommended , will use this power-off outside the pytest environment.

Thanks ,
Adarsh

On Fri, 28 May 2021 at 03:12, Stephen Warren <swarren@wwwdotorg.org> wrote:

> On 5/27/21 2:33 AM, opensource.kab@gmail.com wrote:
> > From: Adarsh Babu Kalepalli <opensource.kab@gmail.com>
> >
> > After executing the test-cases from pytest ,the board
> > is still powered.Shutting down the board power supply at
> > this point ,would keep the board safe.
>
> FWIW, this violates the original design of the test system. Turning the
> board off at the end of the test is a policy decision that not all
> use-cases will want, and hence not something that the test system should
> mandate. Instead, the intention is for the user to invoke the test
> system using a script that does something like:
>
> 1) Power on board.
> 2) Run test.
> 3) Power off board.
>
> See ./doc/develop/py_testing.rst in the U-Boot source for more
> background info, or the following URL for an example script:
>
> https://github.com/swarren/u-boot-ci-scripts/blob/master/test.sh
>