From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFDBC4707F for ; Thu, 27 May 2021 10:42:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFF6E613CC for ; Thu, 27 May 2021 10:42:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFF6E613CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD93F82B89; Thu, 27 May 2021 12:42:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 20D5082D4B; Thu, 27 May 2021 12:42:05 +0200 (CEST) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8686E82052 for ; Thu, 27 May 2021 12:42:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 14RAfZ9f040663; Thu, 27 May 2021 18:41:35 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Thu, 27 May 2021 18:41:36 +0800 Date: Thu, 27 May 2021 18:41:35 +0800 From: Leo Liang To: Green Wan CC: Tom Rini , Rick Jian-Zhi =?utf-8?B?Q2hlbijpmbPlu7rlv5cp?= , U-Boot Mailing List Subject: Re: [PULL] u-boot-riscv/master Message-ID: <20210527104135.GA1691@andestech.com> References: <20210526081249.GA19414@andestech.com> <20210526152435.GF17669@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 14RAfZ9f040663 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On Thu, May 27, 2021 at 04:57:17PM +0800, Green Wan wrote: > Hi Tom, > > Thanks for the comments. > > Not sure whether it catches different concerns, I plan to remove fdt_high and initrd_high since the bootm_* settings should be sufficient to calculate the values related to fdt_high and initrd_high. And I checked the bootm_* settings as below, the system can > boot without fdt_high and initrd_high. > > - bootm_low is set to CONFIG_SYS_SDRAM_BASE > - bootm_size is set to gd->ram_size (which comes from DT) > - bootm_mapsize is now equal to bootm_size > - boot log without fdt_high and initrd_high > "## Flattened Device Tree blob at 88000000 > Booting using the fdt blob at 0x88000000 > Loading Device Tree to 00000000ffffa000, end 00000000fffff64d ... OK" > > Hi Leo/Rick, > > Should I create v12 for fu740 series patchset based on u-boot-riscv.git ? or revert [PATCH v11 7/8] plus a patch? Thanks a lot! > > Regards, > Green Hi Green, I think you could just create v12 patch. I will do the revert, thanks! Best regards, Leo > > > > On Wed, May 26, 2021 at 11:24 PM Tom Rini <trini@konsulko.com> wrote: > > > > > > On Wed, May 26, 2021 at 04:12:50PM +0800, Leo Liang wrote: > > > > Hi Tom, > > > > The following changes since commit eb53b943be2949ca111140a8e05532cd74cda058: > > > > Merge https://source.denx.de/u-boot/custodians/u-boot-sh (2021-05-23 10:15:15 -0400) > > > > are available in the Git repository at: > > > > > > git@source.denx.de:u-boot/custodians/u-boot-riscv.git > > > > for you to fetch changes up to 9358576a281ab5e3b7348685bbd5f713833a5048: > > > > drivers: pci: pcie_dw_common: fix Werror compilation error (2021-05-24 23:54:54 +0800) > > > > Gitlab CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/7620 > > NAK. > ERROR: fdt or initrd relocation disabled at boot time > #993: FILE: include/configs/sifive-unmatched.h:65: > +       "fdt_high=0xffffffffffffffff\0" \ > > ERROR: fdt or initrd relocation disabled at boot time > #994: FILE: include/configs/sifive-unmatched.h:66: > +       "initrd_high=0xffffffffffffffff\0" \ > > You can, but shouldn't disable initrd relocation.  You cannot disable > device tree relocation as that leads to too many issues due to > misalignment later.  Make use of bootm_size or similar to make sure > everything is within an appropriate area of memory.  Thanks. > > -- > Tom