public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexandru Gagniuc <mr.nuke.me@gmail.com>
To: u-boot@lists.denx.de, trini@konsulko.com, patrick.delaunay@foss.st.com
Cc: Alexandru Gagniuc <mr.nuke.me@gmail.com>,
	sjg@chromium.org, etienne.carriere@linaro.org
Subject: [PATCH v4 2/5] spl: Introduce spl_board_prepare_for_optee() hook
Date: Mon, 31 May 2021 12:43:11 -0500	[thread overview]
Message-ID: <20210531174314.1395666-3-mr.nuke.me@gmail.com> (raw)
In-Reply-To: <20210531174314.1395666-1-mr.nuke.me@gmail.com>

OP-TEE requires some particular setup, which is not needed for linux
or other payloads. Add a hook for platform-specific code to perform
any OP-TEE related configuration and initialization.

A weak function is used because it is symmetrical to other
spl_board_prepare_for_*() implementations. A solution to avoid the use
of weak functions would trivially apply to all these implementations.
However, re-designing this is beyond the scope of this patch.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
 common/spl/spl.c |  5 +++++
 include/spl.h    | 14 ++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index a0a608fd772..56f6d47b164 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -165,6 +165,10 @@ __weak void spl_board_prepare_for_linux(void)
 	/* Nothing to do! */
 }
 
+__weak void spl_board_prepare_for_optee(void *fdt)
+{
+}
+
 __weak void spl_board_prepare_for_boot(void)
 {
 	/* Nothing to do! */
@@ -745,6 +749,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 #if CONFIG_IS_ENABLED(OPTEE)
 	case IH_OS_TEE:
 		debug("Jumping to U-Boot via OP-TEE\n");
+		spl_board_prepare_for_optee(spl_image.fdt_addr);
 		spl_optee_entry(NULL, NULL, spl_image.fdt_addr,
 				(void *)spl_image.entry_point);
 		break;
diff --git a/include/spl.h b/include/spl.h
index cee9a42ddb5..04ab2b6d7d8 100644
--- a/include/spl.h
+++ b/include/spl.h
@@ -388,6 +388,20 @@ int spl_parse_image_header(struct spl_image_info *spl_image,
 			   const struct image_header *header);
 
 void spl_board_prepare_for_linux(void);
+
+/**
+ * spl_board_prepare_for_optee() - Prepare board for an OPTEE payload
+ *
+ * Prepares the board for booting an OP-TEE payload. Initialization is platform
+ * specific, and may include configuring the TrustZone memory, and other
+ * initialization steps required by OP-TEE.
+ * Note that @fdt is not used directly by OP-TEE. OP-TEE passes this @fdt to
+ * its normal world target. This target is not guaranteed to be u-boot, so @fdt
+ * changes that would normally be done by u-boot should be done in this step.
+ *
+ * @fdt: Devicetree that will be passed on, or NULL
+ */
+void spl_board_prepare_for_optee(void *fdt);
 void spl_board_prepare_for_boot(void);
 int spl_board_ubi_load_image(u32 boot_device);
 int spl_board_boot_device(u32 boot_device);
-- 
2.31.1


  parent reply	other threads:[~2021-05-31 17:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 17:43 [PATCH v4 0/5] stm32mp: Enable OP-TEE and TZC support in SPL Alexandru Gagniuc
2021-05-31 17:43 ` [PATCH v4 1/5] spl: mmc: Support OP-TEE payloads in Falcon mode Alexandru Gagniuc
2021-07-15 18:27   ` Patrick DELAUNAY
2021-07-15 19:11     ` Alex G.
2021-07-15 19:19     ` [PATCH v5 0/5] stm32mp: Enable OP-TEE and TZC support in SPL Alexandru Gagniuc
2021-07-15 19:19       ` [PATCH v5 1/5] spl: mmc: Support OP-TEE payloads in Falcon mode Alexandru Gagniuc
2021-07-27  9:12         ` Patrick DELAUNAY
2021-07-15 19:19       ` [PATCH v5 2/5] spl: Introduce spl_board_prepare_for_optee() hook Alexandru Gagniuc
2021-07-27  9:13         ` Patrick DELAUNAY
2021-07-15 19:19       ` [PATCH v5 3/5] arm: stm32mp: Implement support for TZC 400 controller Alexandru Gagniuc
2021-07-27  9:14         ` Patrick DELAUNAY
2021-07-15 19:19       ` [PATCH v5 4/5] stm32mp1: spl: Configure TrustZone controller for OP-TEE Alexandru Gagniuc
2021-07-27  9:14         ` Patrick DELAUNAY
2021-07-15 19:19       ` [PATCH v5 5/5] ARM: dts: stm32mp: Add OP-TEE reserved memory to SPL dtb Alexandru Gagniuc
2021-07-27  9:15         ` Patrick DELAUNAY
2021-07-25 15:08       ` [PATCH v5 0/5] stm32mp: Enable OP-TEE and TZC support in SPL Alex G.
2021-05-31 17:43 ` Alexandru Gagniuc [this message]
2021-05-31 17:43 ` [PATCH v4 3/5] arm: stm32mp: Implement support for TZC 400 controller Alexandru Gagniuc
2021-05-31 17:43 ` [PATCH v4 4/5] stm32mp1: spl: Configure TrustZone controller for OP-TEE Alexandru Gagniuc
2021-07-08 13:23   ` Patrice CHOTARD
2021-07-09  9:03   ` Patrick DELAUNAY
2021-05-31 17:43 ` [PATCH v4 5/5] ARM: dts: stm32mp: Add OP-TEE reserved memory to SPL dtb Alexandru Gagniuc
2021-06-01 15:02   ` Patrick DELAUNAY
2021-07-06 15:18 ` [PATCH v4 0/5] stm32mp: Enable OP-TEE and TZC support in SPL Alex G.
2021-07-06 15:45   ` Tom Rini
2021-07-06 15:55     ` Alex G.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210531174314.1395666-3-mr.nuke.me@gmail.com \
    --to=mr.nuke.me@gmail.com \
    --cc=etienne.carriere@linaro.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox