public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tero Kristo <kristo@kernel.org>
To: u-boot@lists.denx.de, lokeshvutla@ti.com
Cc: trini@konsulko.com
Subject: [PATCHv5 06/26] clk: fix clock tree dump to properly dump out every registered clock
Date: Thu,  3 Jun 2021 09:32:35 +0300	[thread overview]
Message-ID: <20210603063255.5483-7-kristo@kernel.org> (raw)
In-Reply-To: <20210603063255.5483-1-kristo@kernel.org>

From: Tero Kristo <t-kristo@ti.com>

Some clocks are not associated to a DM node, so just parsing the DM is not
enough. This is especially true for root clocks, which typically don't have
any parents. Instead, fetch every registered UCLASS_CLK instance, and dump
these out.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tero Kristo <kristo@kernel.org>
---
 cmd/clk.c | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/cmd/clk.c b/cmd/clk.c
index e3c3d2f9bb..0245b97136 100644
--- a/cmd/clk.c
+++ b/cmd/clk.c
@@ -18,11 +18,14 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
 {
 	int i, is_last;
 	struct udevice *child;
-	struct clk *clkp;
+	struct clk *clkp, *parent;
 	u32 rate;
 
 	clkp = dev_get_clk_ptr(dev);
 	if (device_get_uclass_id(dev) == UCLASS_CLK && clkp) {
+		parent = clk_get_parent(clkp);
+		if (!IS_ERR(parent) && depth == -1)
+			return;
 		depth++;
 		rate = clk_get_rate(clkp);
 
@@ -47,6 +50,9 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
 	}
 
 	list_for_each_entry(child, &dev->child_head, sibling_node) {
+		if (child == dev)
+			continue;
+
 		is_last = list_is_last(&child->sibling_node, &dev->child_head);
 		show_clks(child, depth, (last_flag << 1) | is_last);
 	}
@@ -54,14 +60,19 @@ static void show_clks(struct udevice *dev, int depth, int last_flag)
 
 int __weak soc_clk_dump(void)
 {
-	struct udevice *root;
+	struct udevice *dev;
+	struct uclass *uc;
+	int ret;
 
-	root = dm_root();
-	if (root) {
-		printf(" Rate               Usecnt      Name\n");
-		printf("------------------------------------------\n");
-		show_clks(root, -1, 0);
-	}
+	ret = uclass_get(UCLASS_CLK, &uc);
+	if (ret)
+		return ret;
+
+	printf(" Rate               Usecnt      Name\n");
+	printf("------------------------------------------\n");
+
+	uclass_foreach_dev(dev, uc)
+		show_clks(dev, -1, 0);
 
 	return 0;
 }
-- 
2.17.1


  parent reply	other threads:[~2021-06-03  6:34 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  6:32 [PATCHv5 00/26] Re-base / re-post of TI-K3 HSM rearch series Tero Kristo
2021-06-03  6:32 ` [PATCHv5 01/26] lib: rational: copy the rational fraction lib routines from Linux Tero Kristo
2021-06-03  6:32 ` [PATCHv5 02/26] arm: mach-k3: introduce new config option for sysfw split Tero Kristo
2021-06-03  6:32 ` [PATCHv5 03/26] remoteproc: k3-r5: remove sysfw PM calls if not supported Tero Kristo
2021-06-03  6:32 ` [PATCHv5 04/26] common: fit: Update board_fit_image_post_process() to pass fit and node_offset Tero Kristo
2021-06-09 10:33   ` Tero Kristo
2021-06-03  6:32 ` [PATCHv5 05/26] clk: fixed_rate: add API for directly registering fixed rate clocks Tero Kristo
2021-06-03  6:32 ` Tero Kristo [this message]
2021-06-03  6:32 ` [PATCHv5 07/26] clk: do not attempt to fetch clock pointer with null device Tero Kristo
2021-06-03  6:32 ` [PATCHv5 08/26] clk: add support for setting clk rate from cmdline Tero Kristo
2021-06-03  6:32 ` [PATCHv5 09/26] clk: sci-clk: fix return value of set_rate Tero Kristo
2021-06-03  6:32 ` [PATCHv5 10/26] clk: fix assigned-clocks to pass with deferring provider Tero Kristo
2021-06-03  6:32 ` [PATCHv5 11/26] clk: fix set_rate to clean up cached rates for the hierarchy Tero Kristo
2021-06-03  6:32 ` [PATCHv5 12/26] clk: add support for TI K3 SoC PLL Tero Kristo
2021-06-03  6:32 ` [PATCHv5 13/26] clk: add support for TI K3 SoC clocks Tero Kristo
2021-06-03  6:32 ` [PATCHv5 14/26] power: domain: Introduce driver for raw TI K3 PDs Tero Kristo
2021-06-03  6:32 ` [PATCHv5 15/26] cmd: ti: pd: Add debug command for K3 power domains Tero Kristo
2021-06-03  6:32 ` [PATCHv5 16/26] tools: k3_fit_atf: add DM binary to the FIT image Tero Kristo
2021-06-03  6:32 ` [PATCHv5 17/26] arm: mach-k3: Add platform data for j721e and j7200 Tero Kristo
2021-06-03  6:32 ` [PATCHv5 18/26] arm: mach-k3: add support for detecting firmware images from FIT Tero Kristo
2021-06-03  6:32 ` [PATCHv5 19/26] arm: mach-k3: do board config for PM only if supported Tero Kristo
2021-06-03  6:32 ` [PATCHv5 20/26] arm: mach-k3: common: Drop main r5 start Tero Kristo
2021-06-03  6:32 ` [PATCHv5 21/26] arm: mach-k3: sysfw-loader: pass boardcfg to sciserver Tero Kristo
2021-06-03  6:32 ` [PATCHv5 22/26] arm: mach-k3: j721e_init: Force early probe of clk-k3 driver Tero Kristo
2021-06-03  6:32 ` [PATCHv5 23/26] configs: j721e_evm_r5: Enable raw access power management features Tero Kristo
2021-06-03  6:32 ` [PATCHv5 24/26] configs: j7200_evm_r5: " Tero Kristo
2021-06-03  6:32 ` [PATCHv5 25/26] board: ti: j72xx: README: update build instructions and image formats Tero Kristo
2021-06-03  6:32 ` [PATCHv5 26/26] arm: dts: k3-j72xx: correct MCU timer1 frequency Tero Kristo
2021-06-07 11:22 ` [PATCHv5 00/26] Re-base / re-post of TI-K3 HSM rearch series Lokesh Vutla
2021-06-08  6:27   ` Tero Kristo
2021-06-08  6:32     ` Lokesh Vutla
2021-06-08  6:43       ` Tero Kristo
2021-06-09 16:59 ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603063255.5483-7-kristo@kernel.org \
    --to=kristo@kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox