From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F6BC47082 for ; Thu, 3 Jun 2021 15:14:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E30FD613F3 for ; Thu, 3 Jun 2021 15:14:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E30FD613F3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 067CF82F3C; Thu, 3 Jun 2021 17:14:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Nb2YMRP6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F39FC82FB1; Thu, 3 Jun 2021 17:14:15 +0200 (CEST) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 02BB982F3C for ; Thu, 3 Jun 2021 17:14:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id d7so1072075qvo.5 for ; Thu, 03 Jun 2021 08:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nu3eDL7H5eu05LZ8RPRKkbFDnfOtFfay5xyGrxGzfR0=; b=Nb2YMRP6Hh+/vbDfebGenIGGr1Y/Cp6vJHaRArVLWd35QzZbleIq1qiJFbx2dEmV7p k67nbV8hoFln0/Dz/Hr/G9D3Qi6iGFNHCwwP36KvclUv0WdOMcQqdf+JNFyGZ/yPB+nO r8+9EbMDkB/Y2uHZkSfq3UP06TkeMLYY0+uao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nu3eDL7H5eu05LZ8RPRKkbFDnfOtFfay5xyGrxGzfR0=; b=kNNmYCPv3/Fo4WnKsRv2nke0t4QXcdFBEIHD21CDqzP2Ud35KCFvPvd+uT5gkMYcbe TEH1IMR0TGFI45W/DNXABHK/QZsUO8pfNPHQMEqvdyXNtAxWblLlWfEqyBGtSrEtsJqB KfVTzJ93IDVG+RM6AAMUGKQUQQQCZd8wVvr4nCCS0JWqL0AihjljYqdXUXE00VEYFMYD Y+VO3+mgAv4ja67As4zzJczWbxX2fAGi/MQIJnVzQyyFR5qXf8N9f07+d8w8ljYkgEzT D7tl/6Uq2mgBZBHIDgE+SOr6GL7JIUGId7jvT9iBbh0fp2Rtj+BCoKevoeCsKi7C2f4C qRAQ== X-Gm-Message-State: AOAM53099a8fv4wHuZ40EcZc6ddpZu75Dh5GnSLP4rQky5bHfDzZ0RXF kOVuvSmxgOY0ubAWOcQOtkYnH8Z16BXETg== X-Google-Smtp-Source: ABdhPJwP1zBSm2n+vGvy2qTFPAg3uG3VS0Y7mDOBTimcDkpXpcs0d8C6xmZNU0sNq4IxWYrU+Au4eQ== X-Received: by 2002:ad4:4502:: with SMTP id k2mr282891qvu.43.1622733250752; Thu, 03 Jun 2021 08:14:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-adda-a854-910e-c3a3.res6.spectrum.com. [2603:6081:7b01:cbda:adda:a854:910e:c3a3]) by smtp.gmail.com with ESMTPSA id b5sm2081314qkn.129.2021.06.03.08.14.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Jun 2021 08:14:10 -0700 (PDT) Date: Thu, 3 Jun 2021 11:14:08 -0400 From: Tom Rini To: Rasmus Villemoes Cc: u-boot Subject: Re: [PATCH 3/4] socfpga64: Do not define CONFIG_SYS_MEM_RESERVE_SECURE to 0 Message-ID: <20210603151408.GL14385@bill-the-cat> References: <20210518091947.63513-1-rasmus.villemoes@prevas.dk> <20210603133902.4192-1-trini@konsulko.com> <20210603133902.4192-3-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fmEUq8M7S0s+Fl0V" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --fmEUq8M7S0s+Fl0V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 03, 2021 at 05:07:17PM +0200, Rasmus Villemoes wrote: > On 03/06/2021 15.39, Tom Rini wrote: > > Based on the comment in socfpga_soc64_common.h, the intention is for > > CONFIG_SYS_MEM_RESERVE_SECURE to be unused. However, in the code we do: > > ... > >=20 > > and that will evaluate to true. This leads to unwanted code being >=20 > Some cleanup made lines beginning with # disappear? I can _strongly_ > recommend setting commit.cleanup to scissors; I have lost count of the > number of times I've had a commit message mangled and become practically > useless because important lines got removed. >=20 > For example > > became > Bah! Yes, thanks. It should have said #ifdef CONFIG_SYS_MEM_RESERVE_SECURE =2E.. #endif --=20 Tom --fmEUq8M7S0s+Fl0V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmC48bkACgkQFHw5/5Y0 tyxydwv/fKkdGdF9fD6AD2U0g2VFtKMGPkMMJEDrIByDHsJjeI1c94R7cGvUpDUP 2SVqrE9nGMfeevjB/SYFuwel2ZlC4UmNr9A3i7FVj2707LZ4lBfQzDI4Vu9Gghr/ hRLlqWeGwSw4SrXpuQnad+joSp27e7t0sj3ePGN0pBbuuuOSoNJj7hXMFgMu+PVa /e+3Q2wC2WWdI2TmP98N1HLcc4nOlhIAyJcKnpf6Aar+6L69I9XOsKtkYb6pN9tx MRJZmnJgIr2j7s2JJ18782hmgftDlRbrrwk0WhWfPK7sbiQNkj+BgUHU2csPsjK8 3zVRLEdnFXS0Zm/JWubNPtsGyw7bOC+TwD8xCxoZMzSFC9YnO4MJCP9n/XHsYrsY PU267RP+ceSYhANbGeBI3lwTjdB0EkPBny/Aa1zuyePEvETAZRVzYsaNeUw7Ag06 bRYssx476CoyqV17u6OV0T7G1dy2Nf7QtmSUtbpke9KNokT56ZlDEFgtrW20g7/t 23VbZ3/9 =yhtR -----END PGP SIGNATURE----- --fmEUq8M7S0s+Fl0V--