From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Cc: Lukasz Majewski <lukma@denx.de>,
Leo Liang <ycliang@andestech.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Sean Anderson <seanga2@gmail.com>
Subject: [PATCH v2 06/11] clk: k210: Don't set PLL rates if we are already at the correct rate
Date: Thu, 3 Jun 2021 23:58:29 -0400 [thread overview]
Message-ID: <20210604035834.625772-7-seanga2@gmail.com> (raw)
In-Reply-To: <20210604035834.625772-1-seanga2@gmail.com>
This speeds up boot by preventing multiple reconfigurations of the PLLs.
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
(no changes since v1)
drivers/clk/kendryte/clk.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/kendryte/clk.c b/drivers/clk/kendryte/clk.c
index a1742eb856..bb6d4a1692 100644
--- a/drivers/clk/kendryte/clk.c
+++ b/drivers/clk/kendryte/clk.c
@@ -847,21 +847,22 @@ static ulong k210_pll_set_rate(struct k210_clk_priv *priv, int id, ulong rate,
const struct k210_pll_params *pll = &k210_plls[id];
struct k210_pll_config config = {};
u32 reg;
+ ulong calc_rate;
if (rate_in < 0)
return rate_in;
- log_debug("Calculating parameters with rate=%lu and rate_in=%lu\n",
- rate, rate_in);
err = k210_pll_calc_config(rate, rate_in, &config);
if (err)
return err;
log_debug("Got r=%u f=%u od=%u\n", config.r, config.f, config.od);
- /*
- * Don't use clk_disable as it might not actually disable the pll due to
- * refcounting
- */
+ /* Don't bother setting the rate if we're already at that rate */
+ calc_rate = DIV_ROUND_DOWN_ULL(((u64)rate_in) * config.f,
+ config.r * config.od);
+ if (calc_rate == k210_pll_get_rate(priv, id, rate))
+ return calc_rate;
+
k210_pll_disable(priv, id);
reg = readl(priv->base + pll->off);
@@ -875,7 +876,7 @@ static ulong k210_pll_set_rate(struct k210_clk_priv *priv, int id, ulong rate,
| FIELD_PREP(K210_PLL_BWADJ, config.f - 1);
writel(reg, priv->base + pll->off);
- err = k210_pll_enable(priv, id);
+ k210_pll_enable(priv, id);
serial_setbrg();
return k210_pll_get_rate(priv, id, rate);
--
2.31.0
next prev parent reply other threads:[~2021-06-04 4:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 3:58 [PATCH v2 00/11] clk: k210: Rewrite K210 clock without CCF Sean Anderson
2021-06-04 3:58 ` [PATCH v2 01/11] clk: Allow force setting clock defaults before relocation Sean Anderson
2021-06-04 3:58 ` [PATCH v2 02/11] clk: k210: Rewrite to remove CCF Sean Anderson
2021-06-04 3:58 ` [PATCH v2 03/11] clk: k210: Move pll into the rest of the driver Sean Anderson
2021-06-04 3:58 ` [PATCH v2 04/11] clk: k210: Implement soc_clk_dump Sean Anderson
2021-06-04 3:58 ` [PATCH v2 05/11] clk: k210: Re-add support for setting rate Sean Anderson
2021-06-04 4:17 ` Sean Anderson
2021-06-04 3:58 ` Sean Anderson [this message]
2021-06-04 3:58 ` [PATCH v2 07/11] clk: k210: Remove bypass driver Sean Anderson
2021-06-04 3:58 ` [PATCH v2 08/11] clk: k210: Move k210 clock out of its own subdirectory Sean Anderson
2021-06-04 3:58 ` [PATCH v2 09/11] k210: dts: Set PLL1 to the same rate as PLL0 Sean Anderson
2021-06-04 3:58 ` [PATCH v2 10/11] k210: Don't imply CCF Sean Anderson
2021-06-04 3:58 ` [PATCH v2 11/11] test: Add K210 PLL tests to sandbox defconfigs Sean Anderson
2021-06-04 4:28 ` [PATCH v2 00/11] clk: k210: Rewrite K210 clock without CCF Damien Le Moal
2021-06-04 4:40 ` Sean Anderson
2021-06-10 18:00 ` Leo Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604035834.625772-7-seanga2@gmail.com \
--to=seanga2@gmail.com \
--cc=Damien.LeMoal@wdc.com \
--cc=lukma@denx.de \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox