public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: u-boot@lists.denx.de
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	Patrick Wildt <patrick@blueri.se>,
	Kever Yang <kever.yang@rock-chips.com>
Subject: [PATCHv3 3/3] pci: pcie_dw_rockchip: Replace msleep occurences by udelay
Date: Fri,  4 Jun 2021 04:56:07 +0000	[thread overview]
Message-ID: <20210604045607.1003-3-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210604045607.1003-1-linux.amoon@gmail.com>

Replace msleep occurences by udelay.

drivers/pci/pcie_dw_rockchip.c:254:3: warning: implicit
     declaration of function 'msleep' [-Wimplicit-function-declaration]

Cc: Patrick Wildt <patrick@blueri.se>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kever Yang <kever.yang@rock-chips.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V2: drop the msleep macro.
---
 drivers/pci/pcie_dw_rockchip.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
index 4e448c0a3d..039266a357 100644
--- a/drivers/pci/pcie_dw_rockchip.c
+++ b/drivers/pci/pcie_dw_rockchip.c
@@ -62,6 +62,7 @@ struct rk_pcie {
 
 /* Parameters for the waiting for #perst signal */
 #define PERST_WAIT_MS			1000
+#define MACRO_US			1000
 
 static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
 {
@@ -249,7 +250,7 @@ static int rk_pcie_link_up(struct rk_pcie *priv, u32 cap_speed)
 		 * some wired devices need much more, such as 600ms.
 		 * Add a enough delay to cover all cases.
 		 */
-		msleep(PERST_WAIT_MS);
+		udelay(PERST_WAIT_MS);
 		dm_gpio_set_value(&priv->rst_gpio, 1);
 	}
 
@@ -271,12 +272,12 @@ static int rk_pcie_link_up(struct rk_pcie *priv, u32 cap_speed)
 		dev_info(priv->dw.dev, "PCIe Linking... LTSSM is 0x%x\n",
 			 rk_pcie_readl_apb(priv, PCIE_CLIENT_LTSSM_STATUS));
 		rk_pcie_debug_dump(priv);
-		msleep(1000);
+		udelay(PERST_WAIT_MS * MACRO_US);
 	}
 
 	dev_err(priv->dw.dev, "PCIe-%d Link Fail\n", dev_seq(priv->dw.dev));
 	/* Link maybe in Gen switch recovery but we need to wait more 1s */
-	msleep(1000);
+	udelay(PERST_WAIT_MS * MACRO_US);
 	return -EIO;
 }
 
@@ -296,7 +297,7 @@ static int rockchip_pcie_init_port(struct udevice *dev)
 		}
 	}
 
-	msleep(1000);
+	udelay(PERST_WAIT_MS * MACRO_US);
 
 	ret = generic_phy_init(&priv->phy);
 	if (ret) {
-- 
2.31.1


  parent reply	other threads:[~2021-06-04  4:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04  4:56 [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Anand Moon
2021-06-04  4:56 ` [PATCHv3 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning Anand Moon
2021-06-04 15:45   ` Patrick Wildt
2021-06-08  7:05   ` Kever Yang
2021-06-04  4:56 ` Anand Moon [this message]
2021-06-04 15:44   ` [PATCHv3 3/3] pci: pcie_dw_rockchip: Replace msleep occurences by udelay Patrick Wildt
2021-06-05 11:56     ` Anand Moon
2021-06-08  7:06   ` Kever Yang
2021-06-04 15:46 ` [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Patrick Wildt
2021-06-08  7:05 ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604045607.1003-3-linux.amoon@gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=kever.yang@rock-chips.com \
    --cc=narmstrong@baylibre.com \
    --cc=patrick@blueri.se \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox