From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F68C47082 for ; Mon, 7 Jun 2021 08:39:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2EC66115B for ; Mon, 7 Jun 2021 08:39:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2EC66115B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9637B82836; Mon, 7 Jun 2021 10:39:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1623055194; bh=3h/Hh4CbP9KuirkXpl6M1IN7n/c8vtpW6ti/CDVSoSM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZqVocFyg6ULUiCYrcMI9RN39qQdHenbxR+o9xTinbXtz2iZeKAsGtoeQ4bU868Kkp MaRzKfj/6hEuvZ0nWcoFc/2pthRbVoHq03+dxEc1bUP9fEn2E82Ka1Q7GoNf4p7gIO VfmI8zqpWZMKiv4l0DrksFZTc6OFPkZY9ZMnvRn+hR3QRf80nck/v7eOw5qqGNuSxb e/FHMb5Fa7azcP8gwM3Up3MfKE3X0B5Xmv6bx6dtvDHh5Y+K11l2tXAp4y06RUPAJh hs26xXPlulID2hgl+pZzeOs6y6+h4U/hGFAZ6M5cIa8u/tKiYy2IqKy07E3Y5kDSZj TOu0XCpt8nh8A== Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 875AA814A4; Mon, 7 Jun 2021 10:39:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1623055192; bh=3h/Hh4CbP9KuirkXpl6M1IN7n/c8vtpW6ti/CDVSoSM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ybs0i8pF+WCoAbPLsIVLGHlU4lS3MSJGoZzMqJqk8FJt836zJzzCTfvaWQ5i1aDnh t4abdhJkGHRKvy1M/7Mnjouw0Yi/qUC9SdaUk2DYs3qWUa2zgLrIWyozsy+kJpI6H/ fgdR02fJWS9y7xsQ0vjYV2coJOEBsUdUms+qtiB+0HXC6ZxcaNgbuB5HxYShH02Pij rLdmsonubbjdR8sfpvcf18RrlFsV/vwRL7Pt2fWe8mmOaLdzTqjx2bWUgsm5d18tE5 tYI3m+q4C7+4Jg87D65OGe3KqqwmYkUeBwwRtBeOlKwBcX6+z7vWJq7u8INCWpfaSy +Qf0v6mi8NTUQ== Date: Mon, 7 Jun 2021 10:39:46 +0200 From: Lukasz Majewski To: Patrick DELAUNAY Cc: Patrice CHOTARD , , U-Boot STM32 , Marek Vasut Subject: Re: [Uboot-stm32] [PATCH] dfu: dfu_mtd: set max_buf_size to erasesize also for NOR devices Message-ID: <20210607103946.5e235a20@ktm> In-Reply-To: <0616d868-1939-e0dc-3d3a-8e4b150a95e9@foss.st.com> References: <20210304174748.1.I1d824180669d63e22275f082e7ac0fe50c2b8646@changeid> <48f7454f-6bae-224c-bba3-4b24e81e800b@foss.st.com> <0616d868-1939-e0dc-3d3a-8e4b150a95e9@foss.st.com> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/0aL5ZImmmDTLmEN_=sfHA3t"; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --Sig_/0aL5ZImmmDTLmEN_=sfHA3t Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Patrick, > Thanks Patrice, >=20 > On 4/20/21 12:24 PM, Patrice CHOTARD wrote: > > Hi Patrick > > > > On 3/4/21 5:47 PM, Patrick Delaunay wrote: =20 > >> For NOR devices the logical DFU buffer size is the sector_size, > >> as it is done in dfu_sf.c or in spi/sf_mtd.c > >> (sf_mtd_info.erasesize =3D flash->sector_size) > >> > >> For NAND the DFU size was already limited to erasesize as > >> has_pages =3D true. > >> > >> So the mtd dfu backend can use this erasesize for all the MTD > >> devices, NOR and NAND with dfu->max_buf_size =3D mtd->erasesize > >> > >> This difference was initially copied from MTD command, where > >> data is fully available in RAM without size limitation. > >> > >> This patch avoids to have many sector write in dfu_mtd.c at the end > >> of the DFU transfer and avoids issues with USB timeout or WATCHDOG. > >> > >> Signed-off-by: Patrick Delaunay > >> --- > >> > >> drivers/dfu/dfu_mtd.c | 5 +---- > >> 1 file changed, 1 insertion(+), 4 deletions(-) > >> > >> diff --git a/drivers/dfu/dfu_mtd.c b/drivers/dfu/dfu_mtd.c > >> index ca67585a7e..7efb3cbd79 100644 > >> --- a/drivers/dfu/dfu_mtd.c > >> +++ b/drivers/dfu/dfu_mtd.c > >> @@ -252,7 +252,6 @@ int dfu_fill_entity_mtd(struct dfu_entity > >> *dfu, char *devstr, char *s) { > >> char *st; > >> struct mtd_info *mtd; > >> - bool has_pages; > >> int ret, part; > >> =20 > >> mtd =3D get_mtd_device_nm(devstr); > >> @@ -262,9 +261,7 @@ int dfu_fill_entity_mtd(struct dfu_entity > >> *dfu, char *devstr, char *s)=20 > >> dfu->dev_type =3D DFU_DEV_MTD; > >> dfu->data.mtd.info =3D mtd; > >> - > >> - has_pages =3D mtd->type =3D=3D MTD_NANDFLASH || mtd->type =3D=3D > >> MTD_MLCNANDFLASH; > >> - dfu->max_buf_size =3D has_pages ? mtd->erasesize : 0; > >> + dfu->max_buf_size =3D mtd->erasesize; > >> =20 > >> st =3D strsep(&s, " "); > >> if (!strcmp(st, "raw")) { > >> =20 > > Reviewed-by: Patrice Chotard > > > > Thanks > > > > Patrice =20 >=20 >=20 > Lukasz, any remarks on your side? >=20 >=20 > Can I take this patch in my first STM32 pull request for v2020.10 ? Please pull it to your tree. >=20 > or a PR is already planed on your side ? >=20 > http://patchwork.ozlabs.org/project/uboot/patch/20210304174748.1.I1d82418= 0669d63e22275f082e7ac0fe50c2b8646@changeid/ >=20 >=20 > Regards >=20 > Patrick >=20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/0aL5ZImmmDTLmEN_=sfHA3t Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmC921IACgkQAR8vZIA0 zr2Kvwf+Kl4zDARV5UuqqUjbVlOTi3lTrCKxl1PHCqpQGa09GQYxZaQKVWSxx9c0 kqgDr7WH6jqCNYRWAExspGZ/2esoUXTELDcC7zhWfyxy67MhngfdmE6rGfKNKOCs v1Rd30rGcOOFHaMMkQWn/23n4f6QHJV6NbJchyrcYVWir6i8qjFLoP9/xt/FV6Aq 1oUkLEQn4ewiAF/9TxxSWE8NUFp96BjnUQcoJr/PEUfQWbKGZCngwyqqiKtMrKmp jXDAca3IgYU7XBx93QLb+DwA2a7ltoaZyfSzEWfpGE5pggVCcRby4VF6zacgdY7T GsO3PAK3Ni8JmDWvvkN7gca/OpZ9/g== =Q5cn -----END PGP SIGNATURE----- --Sig_/0aL5ZImmmDTLmEN_=sfHA3t--