From: Tom Rini <trini@konsulko.com>
To: "João Marcos Costa" <jmcosta944@gmail.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Simon Glass <sjg@chromium.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Richard Genoud <richard.genoud@posteo.net>
Subject: Re: [PATCH] fs/squashfs: fix reading of fragmented files
Date: Wed, 9 Jun 2021 14:48:40 -0400 [thread overview]
Message-ID: <20210609184840.GL9516@bill-the-cat> (raw)
In-Reply-To: <CABfBAmAid6M9wrJvBeGVgKVMYRM3hdU4W1HkskeDS+QiKUR=Pw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On Wed, Jun 09, 2021 at 03:21:54PM -0300, João Marcos Costa wrote:
> Hello,
>
> In fact, I really think this patch should be applied to master as soon
> as possible, since the actual unsafety comes from the current code,
> which may read past the fragment_block buffer size.
> Besides, the patch series I sent to rewrite the test suite needs this
> fix, and the current test suite is error-prone, as it was already
> reported.
OK. So, some local testing shows that we'll need to move the CI images
up to a newer base in order to have mksquashfs new enough to support
zstd. Today I guess the failure is just ignored (not great!). I'll
take the bugfix now and we'll do the tests soon.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-06-09 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 21:20 [PATCH] fs/squashfs: fix reading of fragmented files Joao Marcos Costa
2021-05-20 9:54 ` Richard Genoud
2021-05-20 12:51 ` João Marcos Costa
2021-05-26 7:52 ` Miquel Raynal
2021-05-26 12:35 ` João Marcos Costa
2021-06-09 13:16 ` João Marcos Costa
2021-06-09 17:40 ` Tom Rini
2021-06-09 18:21 ` João Marcos Costa
2021-06-09 18:32 ` João Marcos Costa
2021-06-09 18:48 ` Tom Rini [this message]
2021-06-10 0:58 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609184840.GL9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=jmcosta944@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard.genoud@posteo.net \
--cc=sjg@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox