From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 813B1C48BCD for ; Wed, 9 Jun 2021 18:48:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51BFC613E3 for ; Wed, 9 Jun 2021 18:48:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51BFC613E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1DC5482E2F; Wed, 9 Jun 2021 20:48:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Ok85fo8y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 71E8582ECD; Wed, 9 Jun 2021 20:48:47 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77EF982D73 for ; Wed, 9 Jun 2021 20:48:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id l17so14709970qtq.12 for ; Wed, 09 Jun 2021 11:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bBlitDLc2iSwhzlNbjR7pkesm5arA7AZFPLfNaYiqg4=; b=Ok85fo8ye4FkECgnjsiwUzi00f/QYV39IEEblVoqZ2JVv7x/sLCSVPKuDJMgsD7bIO DQMGCg1Xc2Q9sjCnk5PJ2oaV5TO7Ziqo57MhO7/qBrkGN8J3OSWBW3q/Hzb7ZAZa1ftj MLlfnw1mnKYek0uf2n+Lt4yrAD6rEI1hN80kI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bBlitDLc2iSwhzlNbjR7pkesm5arA7AZFPLfNaYiqg4=; b=q8tlnfZ6Ba5h1Kckp9ZvRVmdBSDlE9B9rTJ1M/WHUdTnlg2ZW6FTrUx92OxpB3KeNv fW00k5NtV6ZOfwQUHt6kYt1gX/SZ/W7pI62g2/JlOnmUVcsuXlG2ciE3wDXz+LczKOv5 QpX9vzAuoFM3bLnJd0MhxlLpKLXY44FYZXAPYmktLQdCBAy5gzloWm1eOsTmt6mhWf+r vtuP+PmECl1i0vLbA7mNWse7MgqXjbswaj2q2V9wcGIgWUO9Lr1dbq4ALRxvvLNnhj4x nTQQrbJlzkdOFu5kKONRtssm/L8P48akS7mYejD3zY7Qhwc0tLfUUkZv3mAixX/omatf cBLg== X-Gm-Message-State: AOAM531fR+FH73biqVxlcHrtoHfaNCgFw2981Ovun/Qe22I1+WZ8JK0e LKrhZ8PcuTQy/Q+WDgwVWNTOHA== X-Google-Smtp-Source: ABdhPJwCIMKBAds7F4wPOSnGwwRkiElPQ6y0CK/VWKgEs8emEoOxqPEX1FsciqIMbEM2bdSQHlmLxA== X-Received: by 2002:ac8:6745:: with SMTP id n5mr1303853qtp.275.1623264523121; Wed, 09 Jun 2021 11:48:43 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-4157-2a7b-ef5c-df25.res6.spectrum.com. [2603:6081:7b01:cbda:4157:2a7b:ef5c:df25]) by smtp.gmail.com with ESMTPSA id f5sm584031qkm.124.2021.06.09.11.48.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Jun 2021 11:48:42 -0700 (PDT) Date: Wed, 9 Jun 2021 14:48:40 -0400 From: Tom Rini To: =?iso-8859-1?Q?Jo=E3o?= Marcos Costa Cc: U-Boot Mailing List , Miquel Raynal , Simon Glass , Thomas Petazzoni , Richard Genoud Subject: Re: [PATCH] fs/squashfs: fix reading of fragmented files Message-ID: <20210609184840.GL9516@bill-the-cat> References: <20210517212038.117284-1-jmcosta944@gmail.com> <20210526095224.17f2e3f8@xps13> <20210609174035.GH9516@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="On39KRpqOYGa2XmA" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --On39KRpqOYGa2XmA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2021 at 03:21:54PM -0300, Jo=E3o Marcos Costa wrote: > Hello, >=20 > In fact, I really think this patch should be applied to master as soon > as possible, since the actual unsafety comes from the current code, > which may read past the fragment_block buffer size. > Besides, the patch series I sent to rewrite the test suite needs this > fix, and the current test suite is error-prone, as it was already > reported. OK. So, some local testing shows that we'll need to move the CI images up to a newer base in order to have mksquashfs new enough to support zstd. Today I guess the failure is just ignored (not great!). I'll take the bugfix now and we'll do the tests soon. --=20 Tom --On39KRpqOYGa2XmA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDBDQIACgkQFHw5/5Y0 tywzEQv8CddGsYRSuz2f5pBSOmzuuay4vPS/0T+OVXqwLa7yJPPuowZ2C3o/Hya6 s3fg0jeKthF9X14nc2p1nFmGJUQBT0xTpxX+X2gCk/VIOy1D4GESUeiBKUYN7NpH VqtBA4J2xZbMV4hHBphJgkSVbg5YQJQ3Hp7+QpB/q3mnfpMqmYiVPYR6DYpw01E6 CB5O3gKT8DMGtQEFce2Jiicva079aFbaqoMrbBVmZG7UvqzG6F7R1C+rblVQ2DPX SaJfcCf1Mm+Idi9o5YfVrp7rU73tayDL/Ljb/ZaZS0sX2Zv88akm7YqY4GaKXUdK S7HW/SowzVpBK/TBb4XJ5O1idRT62ccC78JDRV0F6M/zhAImLa5Y0/TgQgeJZ9tK u5RTz9GA5Q060r04NEIsR82TMvKvvnRyqSsVB25QtwkRINGnBIolANrpXQD96xYo C9m6YZ0s3UQCpNrIu1SgFIeG+gk2m2b4bwEz4Qq3QBWVk4QmatYN7L+/7gPPCYDy SwKCLblY =oK+Q -----END PGP SIGNATURE----- --On39KRpqOYGa2XmA--