From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD2DC48BCD for ; Wed, 9 Jun 2021 20:59:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2989F613EE for ; Wed, 9 Jun 2021 20:59:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2989F613EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C4CBD819C3; Wed, 9 Jun 2021 22:59:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MRNJAdet"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B227F82D73; Wed, 9 Jun 2021 22:59:28 +0200 (CEST) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 06611800D9 for ; Wed, 9 Jun 2021 22:59:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id c10so10842900qvo.9 for ; Wed, 09 Jun 2021 13:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/fIHrGPdPpIrvU6B0+MobYN1NCWRfqbo3s8KwmC5+vA=; b=MRNJAdet+6tKxV2zPONvx2bDTSys1vNeEr1gGtuRbegz4UKuOKa4EgBirrbEtAWVa5 DvB306YedUljAPxEa4jSClPaEaPkSF3L7rxs/klkXomddlhkKnWusTdVQiMU4FoT8E9h IBiPbouNHXqKnqx8NfZD7tLgq3Zw1VK7XKkBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/fIHrGPdPpIrvU6B0+MobYN1NCWRfqbo3s8KwmC5+vA=; b=tjibb2euKCtLYJYcizT5J+ApHCCk+WY/uFSbHEEY+BmVxR6QTvq9i76Jld1isOF25R OzvSWYFYyvKnPx/efp77tcoWmhXCfEL3fWhcAAbY1vgPrl6g4jjzvEkD/k70HFAjINA4 g9Xw6uTo1V6t0XrMF/lSv26q9FdmNiAauAnzk92ezXYA/QLevgWv/WqLfm2PqWSoT0EQ 9wXMU1osNSbxFF+27vY/fLrz6P75K4lG9X8h2qtEQSg9AAOuixe56SQSc4ShF7x1V/gf aG89YUy6mkLdiv/+NYo6OShohn5vVkXofIPRQtQp/Dkulsnvo0j25HIg6mvXXqMA5GEe 8Isw== X-Gm-Message-State: AOAM530LQo/OpghK29ozSPzGfwAwcdXlC8rJJsyIXCvy/uKa/Q1e6hXa Jr/sM3HrOsjQzKaUgGXWoiYXQw== X-Google-Smtp-Source: ABdhPJxif9BrSaxInHlrhFStxSl07n2TZVXEcRewAyoMFcri9BAX3ZlvuCOLQ7SOyWBHPMNqkYxoaA== X-Received: by 2002:ad4:4bc7:: with SMTP id l7mr1979518qvw.7.1623272364780; Wed, 09 Jun 2021 13:59:24 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-b9ef-ba99-589b-078c.res6.spectrum.com. [2603:6081:7b01:cbda:b9ef:ba99:589b:78c]) by smtp.gmail.com with ESMTPSA id 42sm889000qtf.37.2021.06.09.13.59.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 Jun 2021 13:59:24 -0700 (PDT) Date: Wed, 9 Jun 2021 16:59:22 -0400 From: Tom Rini To: Alper Nebi Yasak Cc: u-boot@lists.denx.de, Bin Meng , Heinrich Schuchardt , Daniel Schwierzeck , Simon Glass , Marek Vasut Subject: Re: [PATCH 2/4] Azure: Add fuse device for sandbox test.py tests Message-ID: <20210609205922.GA5699@bill-the-cat> References: <20210604190207.44805-1-alpernebiyasak@gmail.com> <20210604190207.44805-3-alpernebiyasak@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <20210604190207.44805-3-alpernebiyasak@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 04, 2021 at 10:02:04PM +0300, Alper Nebi Yasak wrote: > The EFI secure boot and capsule test setups need to prepare disk images > for their tests using virt-make-fs, which requires access to the host > fuse device. This is not exposed to the docker container by default and > has to be added explicitly. >=20 > Since these tests are marked to run only on the sandbox board, add the > fuse device only when testing on sandbox. >=20 > Signed-off-by: Alper Nebi Yasak > --- >=20 > .azure-pipelines.yml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml > index 35ab7f30b276..a4d796c41895 100644 > --- a/.azure-pipelines.yml > +++ b/.azure-pipelines.yml > @@ -318,7 +318,15 @@ jobs: > # as sandbox testing need create files like spi flash images, = etc. > # (TODO: clean up this in the future) > chmod 777 . > - docker run -v $PWD:$(work_dir) $(ci_runner_image) /bin/bash $(= work_dir)/test.sh > + # Some EFI tests need extra docker args to run > + set -- > + if [[ "${TEST_PY_BD}" =3D=3D "sandbox" ]]; then > + # virt-make-fs needs the fuse device > + if modprobe fuse; then > + set -- "$@" --device /dev/fuse:/dev/fuse > + fi > + fi > + docker run "$@" -v $PWD:$(work_dir) $(ci_runner_image) /bin/ba= sh $(work_dir)/test.sh Thanks for addressing these issues. For this specific patch, I think I would prefer to just always pass in /dev/fuse with a comment about needing it for some tests. --=20 Tom --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDBK6cACgkQFHw5/5Y0 tyzYRQv/da+Vfi/bvegQNT5Ex+MekB5Mv8+KgTkQPOOYjD/CO3jEOjwVrf8TVZ3F Nu1/Lv0GA+JYBJkXpu6B5kZvOKQLfWkE7RZkYrGD8uJxWKBPld04T7fyAk/5uU/Y IxuGzzxAKevefY1usAaB4PZjuKK5WaYUquSis8Fws3vCMT72YDVoI4xYEPP72ZDi UlPhfmz2LePeHbR/5GoLIa1W3+9K4zwQl4q4pP9ncAmG7Uz7wYgyyuE68Agr+wFJ WeCRG6SP39ZA3G/4dU8VupX0YpHZzDTn0GHlJaBjHxTUrh0VQZi2Slvoj2oQ6ZY/ qfEeecwj6phKANzbdSXFijbl/lscFqpzg1oULVaNjFVUgztbirtzYKEIbc8lzCEt 3Wyhn2X6xY6toIMcfHSV/EjFFwfyo51L8sYz9gx/v5yAE9t2ceZ3Rynlk9yTRYsj L4gpkdOZrQRQP1OBtaB8TKjGXLhSMh76vfWrjdw9PXJqafv5INVZcbXtbA+d7u6r YnsAzB/z =UP/3 -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--