[PATCH v1 1/1] test: Include /sbin to the PATH when creating file system

[PATCH v1 1/1] test: Include /sbin to the PATH when creating file system

[Andy Shevchenko]

On some distributions the mkfs is under /sbin and /sbin is not set
for mere users. Include /sbin to the PATH when creating file system,
so that users won't get a scary traceback from Python.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 test/py/tests/test_fs/conftest.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test/py/tests/test_fs/conftest.py b/test/py/tests/test_fs/conftest.py
index 410a675b9714..7325486cdb1a 100644
--- a/test/py/tests/test_fs/conftest.py
+++ b/test/py/tests/test_fs/conftest.py
@@ -159,6 +159,10 @@ def mk_fs(config, fs_type, size, id):
 
     count = (size + 1048576 - 1) / 1048576
 
+    # Some distributions do not add /sbin to the default PATH, where mkfs lives
+    if '/sbin' not in os.environ["PATH"].split(os.pathsep):
+        os.environ["PATH"] += os.pathsep + '/sbin'
+
     try:
         check_call('rm -f %s' % fs_img, shell=True)
         check_call('dd if=/dev/zero of=%s bs=1M count=%d'
-- 
2.30.2

Re: [PATCH v1 1/1] test: Include /sbin to the PATH when creating file system

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

On Thu, Jun 10, 2021 at 06:08:42PM +0300, Andy Shevchenko wrote:

> On some distributions the mkfs is under /sbin and /sbin is not set
> for mere users. Include /sbin to the PATH when creating file system,
> so that users won't get a scary traceback from Python.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]