From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25386C48BDF for ; Fri, 11 Jun 2021 02:38:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DEF561285 for ; Fri, 11 Jun 2021 02:37:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DEF561285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C25182F1D; Fri, 11 Jun 2021 04:37:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MVYWUmH8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B784B82EC9; Fri, 11 Jun 2021 04:37:27 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8375382F04 for ; Fri, 11 Jun 2021 04:37:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=twoerner@gmail.com Received: by mail-qk1-x733.google.com with SMTP id c18so14467286qkc.11 for ; Thu, 10 Jun 2021 19:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+jRISjc/j0MX++YthHAi4I/1ngoMTYrFuzEGSLTBfKk=; b=MVYWUmH8bYhTPxafsNwjULqANDb83Z/mKMeQB5RjlS/MkrCJ6WTZ7yWnowabhSeArO 7uxDgU4q3H+iszlaHy3DI36IVaiKWaH4KZrNLYGyIRg5J4ygNT3SRi2GejF8k4UppUyG BX6riEx3fgSUYS5dVU6hgFS0aqk+7FDgzyt/ldU0WCN2sCZt4guqkPUGBsmJH+C2euaf qjUfHIO6m0R/OKXZsSTiVtX1dqn72HUeRl5G5Mwz+zxG6+agjNC8gJ+3O1LFf7rcKPkn zxsP3TcWHNXzCtRBHji9FWv4GiYhhnmdpnrThA15ghOGyYA+zQw8XfM2U4cBXxgQl7md BthA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+jRISjc/j0MX++YthHAi4I/1ngoMTYrFuzEGSLTBfKk=; b=JeKSROBfECYM8qc4a3PtJRMR5kZF/Wyq69XVoFsyH2lXbhgdJ6Pe+Y9OZI+G44bXFa pHHiUMci2q1JI+MKFoXcinCRVZiTEKlfaczYHMsaiVunMDQQjpRWp/1E7uwpIHqFG56i iQ9z6/HBJeggx1B0O4/Pw3VDE16IqdqyOPs0XQtwTp4mysJxveV1JOFUfHhyVRWs+ebo e7ygBDpUWmLHI2NMc5fWNkZo/AZypPZgQJnYAy5bbpTvjHXmB3ZNwWZsnzt4+4VwKPm2 8WqEDtzYoPyxwo3aePvjzQ+V2LI0N9KOANRO8bOATR03ZYq0FwfwS6fblr/KJzPmgSvv 6EDA== X-Gm-Message-State: AOAM531dpS0HmXgfJL2G1wBjGbk3GN1mg3CsnzzoX3iSXIPVtabPXrYW G8gITH1KsC++gw6HEYzyewK/HSpe1StLdA== X-Google-Smtp-Source: ABdhPJyirbhMnnmdxKVyc8PCwt/KUgwi0RvZ0Hj7pBCdQaWi6AuAimOV40N9S0DRiUfB5sqpEnUobw== X-Received: by 2002:ae9:f30f:: with SMTP id p15mr1696810qkg.151.1623379041022; Thu, 10 Jun 2021 19:37:21 -0700 (PDT) Received: from localhost.localdomain (pppoe-209-91-167-254.vianet.ca. [209.91.167.254]) by smtp.gmail.com with ESMTPSA id m189sm3602444qkd.107.2021.06.10.19.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 19:37:20 -0700 (PDT) From: Trevor Woerner To: U-Boot Mailing List Cc: Heiko Schocher Subject: [PATCH v2 5/8] lpc32xx: i2c: fix base address Date: Thu, 10 Jun 2021 22:37:06 -0400 Message-Id: <20210611023710.35203-5-twoerner@gmail.com> X-Mailer: git-send-email 2.30.0.rc0 In-Reply-To: <20210611023710.35203-1-twoerner@gmail.com> References: <20210611023710.35203-1-twoerner@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean The lpc32xx driver was not obtaining the per-device base address correctly from the device tree. Fix the FIXME in order to get the correct base address. Signed-off-by: Trevor Woerner --- Changes in v2: - added drivers/i2c/lpc32xx_i2c.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/i2c/lpc32xx_i2c.c b/drivers/i2c/lpc32xx_i2c.c index 0ae116617c..6abff263bd 100644 --- a/drivers/i2c/lpc32xx_i2c.c +++ b/drivers/i2c/lpc32xx_i2c.c @@ -282,11 +282,7 @@ static int lpc32xx_i2c_probe(struct udevice *bus) { struct lpc32xx_i2c_dev *dev = dev_get_plat(bus); - /* - * FIXME: This is not permitted - * dev_seq(bus) = dev->index; - */ - + dev->base = dev_read_addr_ptr(bus); __i2c_init(dev->base, dev->speed, 0, dev->index); return 0; } -- 2.30.0.rc0