Re: [PATCH] scripts/get_maintainer.pl: obey ignore list

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

On Thu, Jun 10, 2021 at 11:37:27PM -0400, Trevor Woerner wrote:

> If the user creates a .get_maintainer.ignore file, make sure it is consulted
> and obeyed for *all* emails discovered by the script.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  scripts/get_maintainer.pl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index e3b41616c9..8c0fb8656e 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -2435,6 +2435,7 @@ sub merge_email {
>  
>      for (@_) {
>  	my ($address, $role) = @$_;
> +	next if (ignore_email_address($address));
>  	if (!$saw{$address}) {
>  	    if ($output_roles) {
>  		push(@lines, "$address ($role)");

This got me to check and see that yes, our copy of get_maintainers.pl is
out of date from Linux.  And in fact, a re-sync will let us add a
.get_maintainer.conf file and use upstream a lot more closely as it now
has logic to find all MAINTAINERS files in a tree.

But this change isn't upstream.  Please work with Joe Perches upstream
to get this change accepted and it'll flow down to us and not get
overwritten when I forget it was an intentional change :)  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]